Skip to content

Commit 4284da3

Browse files
author
Batiste Bieler
committed
Fix removeClass as well
1 parent e411c6b commit 4284da3

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/attributes.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,12 @@ jQuery.fn.extend({
3131
removeClass: function( value ) {
3232
if ( (value && typeof value === "string") || value === undefined ) {
3333
var classNames = (value || "").split(/\s+/);
34-
3534
for ( var i = 0, l = this.length; i < l; i++ ) {
3635
var elem = this[i];
37-
3836
if ( elem.nodeType === 1 && elem.className ) {
3937
if ( value ) {
40-
var className = " " + elem.className + " ";
38+
var className = " " + elem.className + " ";
39+
className = className.replace(/[\n\t]/g, " ");
4140
for ( var c = 0, cl = classNames.length; c < cl; c++ ) {
4241
className = className.replace(" " + classNames[c] + " ", " ");
4342
}
@@ -48,7 +47,6 @@ jQuery.fn.extend({
4847
}
4948
}
5049
}
51-
5250
return this;
5351
},
5452

test/unit/attributes.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ test("removeAttr(String", function() {
400400
});
401401

402402
test("addClass, removeClass, hasClass", function() {
403-
expect(10);
403+
expect(12);
404404

405405
var jq = jQuery("<p>Hi</p>"), x = jq[0];
406406

@@ -420,11 +420,15 @@ test("addClass, removeClass, hasClass", function() {
420420
ok( jq.hasClass("hi"), "Check has1" );
421421
ok( jq.hasClass("bar"), "Check has2" );
422422

423-
var jq = jQuery("<p class='class1\nclass2\tcla.ss3'></p>");
423+
var jq = jQuery("<p class='class1\nclass2\tcla.ss3\n'></p>");
424424
ok( jq.hasClass("class1"), "Check hasClass with carriage return" );
425425
ok( jq.hasClass("class2"), "Check hasClass with tab" );
426426
ok( jq.hasClass("cla.ss3"), "Check hasClass with dot" );
427427

428428
jq.removeClass("class2");
429429
ok( jq.hasClass("class2")==false, "Check the class has been properly removed" );
430+
jq.removeClass("cla");
431+
ok( jq.hasClass("cla.ss3"), "Check the dotted class has not been removed" );
432+
jq.removeClass("cla.ss3");
433+
ok( jq.hasClass("cla.ss3")==false, "Check the dotted class has been removed" );
430434
});

0 commit comments

Comments
 (0)