Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit 3d0c1ee

Browse files
Checkboxradio: hiding the icon in horizontal controlgroups with CSS instead of JS. Fixes #5264.
1 parent f02a873 commit 3d0c1ee

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

css/structure/jquery.mobile.forms.checkboxradio.css

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
.ui-checkbox .ui-btn.ui-mini, .ui-radio .ui-btn.ui-mini { margin: .25em 0; }
44
.ui-controlgroup .ui-checkbox .ui-btn, .ui-controlgroup .ui-radio .ui-btn { margin: 0; }
55
.ui-checkbox .ui-btn-inner, .ui-radio .ui-btn-inner { white-space: normal; }
6+
67
.ui-checkbox .ui-btn-icon-left .ui-btn-inner,.ui-radio .ui-btn-icon-left .ui-btn-inner { padding-left: 45px; }
78
.ui-checkbox .ui-mini.ui-btn-icon-left .ui-btn-inner,.ui-radio .ui-mini.ui-btn-icon-left .ui-btn-inner { padding-left: 36px; }
8-
99
.ui-checkbox .ui-btn-icon-right .ui-btn-inner, .ui-radio .ui-btn-icon-right .ui-btn-inner { padding-right: 45px; }
1010
.ui-checkbox .ui-mini.ui-btn-icon-right .ui-btn-inner, .ui-radio .ui-mini.ui-btn-icon-right .ui-btn-inner { padding-right: 36px; }
11-
12-
.ui-checkbox .ui-btn-icon-top .ui-btn-inner,.ui-radio .ui-btn-icon-top .ui-btn-inner { padding-right: 0; padding-left: 0; text-align: center; }
11+
.ui-checkbox .ui-btn-icon-top .ui-btn-inner, .ui-radio .ui-btn-icon-top .ui-btn-inner { padding-right: 0; padding-left: 0; text-align: center; }
1312
.ui-checkbox .ui-btn-icon-bottom .ui-btn-inner, .ui-radio .ui-btn-icon-bottom .ui-btn-inner { padding-right: 0; padding-left: 0; text-align: center; }
14-
1513
.ui-checkbox .ui-icon, .ui-radio .ui-icon { top: 1.1em; }
1614
.ui-checkbox .ui-btn-icon-left .ui-icon, .ui-radio .ui-btn-icon-left .ui-icon { left: 15px; }
1715
.ui-checkbox .ui-mini.ui-btn-icon-left .ui-icon, .ui-radio .ui-mini.ui-btn-icon-left .ui-icon { left: 9px; }
@@ -22,5 +20,12 @@
2220
.ui-checkbox .ui-btn-icon-right .ui-icon, .ui-radio .ui-btn-icon-right .ui-icon { right: 15px; }
2321
.ui-checkbox .ui-mini.ui-btn-icon-right .ui-icon, .ui-radio .ui-mini.ui-btn-icon-right .ui-icon { right: 9px; }
2422

23+
.ui-controlgroup-horizontal .ui-checkbox .ui-icon,
24+
.ui-controlgroup-horizontal .ui-radio .ui-icon { display: none; }
25+
.ui-controlgroup-horizontal .ui-checkbox .ui-btn-inner,
26+
.ui-controlgroup-horizontal .ui-radio .ui-btn-inner { padding: .6em 20px; }
27+
.ui-controlgroup-horizontal .ui-checkbox .ui-mini .ui-btn-inner,
28+
.ui-controlgroup-horizontal .ui-radio .ui-mini .ui-btn-inner { padding: .55em 11px .5em; }
29+
2530
/* input, label positioning */
2631
.ui-checkbox input,.ui-radio input { position:absolute; left:20px; top:50%; width: 10px; height: 10px; margin:-5px 0 0 0; outline: 0 !important; z-index: 1; }

js/widgets/forms/checkboxradio.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ $.widget( "mobile.checkboxradio", $.mobile.widget, {
3434
mini = inheritAttr( input, "mini" ) || o.mini,
3535
checkedState = inputtype + "-on",
3636
uncheckedState = inputtype + "-off",
37-
icon = input.parents( ":jqmData(type='horizontal')" ).length ? undefined : uncheckedState,
37+
icon = uncheckedState,
3838
iconpos = inheritAttr( input, "iconpos" ),
3939
activeBtn = icon ? "" : " " + $.mobile.activeBtnClass,
4040
checkedClass = "ui-" + checkedState + activeBtn,

0 commit comments

Comments
 (0)