Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit 963d895

Browse files
Controlgroup: Target buttons inside the controlgroup-controls container only. Fixes #5352. Changes from PR #5821 with some modifications. Thanks @aristotelos !
1 parent 6b35f75 commit 963d895

File tree

2 files changed

+30
-30
lines changed

2 files changed

+30
-30
lines changed

css/structure/jquery.mobile.controlgroup.css

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,17 @@ fieldset.ui-controlgroup {
88
.ui-field-contain fieldset.ui-controlgroup {
99
margin: 0;
1010
}
11-
.ui-controlgroup .ui-btn,
12-
.ui-controlgroup .ui-checkbox,
13-
.ui-controlgroup .ui-radio,
14-
.ui-controlgroup .ui-select {
11+
.ui-controlgroup-controls .ui-btn,
12+
.ui-controlgroup-controls .ui-checkbox,
13+
.ui-controlgroup-controls .ui-radio,
14+
.ui-controlgroup-controls .ui-select {
1515
margin: 0;
1616
}
17-
.ui-controlgroup .ui-btn:focus,
18-
.ui-controlgroup .ui-btn.ui-focus {
17+
.ui-controlgroup-controls .ui-btn:focus,
18+
.ui-controlgroup-controls .ui-btn.ui-focus {
1919
z-index: 1;
2020
}
21-
.ui-controlgroup li {
21+
.ui-controlgroup-controls li {
2222
list-style: none;
2323
}
2424
.ui-controlgroup-horizontal .ui-controlgroup-controls {
@@ -36,46 +36,46 @@ fieldset.ui-controlgroup {
3636
}
3737
.ui-controlgroup-horizontal .ui-controlgroup-controls > .ui-btn,
3838
.ui-controlgroup-horizontal .ui-controlgroup-controls li > .ui-btn,
39-
.ui-controlgroup-horizontal .ui-checkbox,
40-
.ui-controlgroup-horizontal .ui-radio,
41-
.ui-controlgroup-horizontal .ui-select {
39+
.ui-controlgroup-horizontal .ui-controlgroup-controls .ui-checkbox,
40+
.ui-controlgroup-horizontal .ui-controlgroup-controls .ui-radio,
41+
.ui-controlgroup-horizontal .ui-controlgroup-controls .ui-select {
4242
float: left;
4343
clear: none;
4444
}
45-
.ui-controlgroup-horizontal button.ui-btn,
46-
.ui-controlgroup .ui-btn-icon-notext {
45+
.ui-controlgroup-horizontal .ui-controlgroup-controls button.ui-btn,
46+
.ui-controlgroup-controls .ui-btn-icon-notext {
4747
width: auto;
4848
}
49-
.ui-controlgroup-horizontal .ui-btn-icon-notext,
50-
.ui-controlgroup-horizontal button.ui-btn-icon-notext {
49+
.ui-controlgroup-horizontal .ui-controlgroup-controls .ui-btn-icon-notext,
50+
.ui-controlgroup-horizontal .ui-controlgroup-controls button.ui-btn-icon-notext {
5151
width: 1.5em;
5252
}
53-
.ui-controlgroup .ui-btn-icon-notext {
53+
.ui-controlgroup-controls .ui-btn-icon-notext {
5454
height: auto;
5555
padding: .7em 1em;
5656
}
57-
.ui-controlgroup-vertical .ui-btn {
57+
.ui-controlgroup-vertical .ui-controlgroup-controls .ui-btn {
5858
border-bottom-width: 0;
5959
}
60-
.ui-controlgroup-vertical .ui-btn.ui-last-child {
60+
.ui-controlgroup-vertical .ui-controlgroup-controls .ui-btn.ui-last-child {
6161
border-bottom-width: 1px;
6262
}
63-
.ui-controlgroup-horizontal .ui-btn {
63+
.ui-controlgroup-horizontal .ui-controlgroup-controls .ui-btn {
6464
border-right-width: 0;
6565
}
66-
.ui-controlgroup-horizontal .ui-btn.ui-last-child {
66+
.ui-controlgroup-horizontal .ui-controlgroup-controls .ui-btn.ui-last-child {
6767
border-right-width: 1px;
6868
}
69-
.ui-controlgroup .ui-btn-corner-all,
70-
.ui-controlgroup .ui-btn.ui-corner-all {
69+
.ui-controlgroup-controls .ui-btn-corner-all,
70+
.ui-controlgroup-controls .ui-btn.ui-corner-all {
7171
-webkit-border-radius: 0;
7272
border-radius: 0;
7373
}
74-
.ui-controlgroup .ui-controlgroup-controls,
75-
.ui-controlgroup .ui-radio,
76-
.ui-controlgroup .ui-checkbox,
77-
.ui-controlgroup .ui-select,
78-
.ui-controlgroup li {
74+
.ui-controlgroup-controls,
75+
.ui-controlgroup-controls .ui-radio,
76+
.ui-controlgroup-controls .ui-checkbox,
77+
.ui-controlgroup-controls .ui-select,
78+
.ui-controlgroup-controls li {
7979
-webkit-border-radius: inherit;
8080
border-radius: inherit;
8181
}
@@ -103,9 +103,9 @@ fieldset.ui-controlgroup {
103103
-webkit-border-bottom-right-radius: inherit;
104104
border-bottom-right-radius: inherit;
105105
}
106-
.ui-controlgroup a.ui-shadow:not(:focus),
107-
.ui-controlgroup button.ui-shadow:not(:focus),
108-
.ui-controlgroup div.ui-shadow:not(.ui-focus) {
106+
.ui-controlgroup-controls a.ui-shadow:not(:focus),
107+
.ui-controlgroup-controls button.ui-shadow:not(:focus),
108+
.ui-controlgroup-controls div.ui-shadow:not(.ui-focus) {
109109
-moz-box-shadow: none;
110110
-webkit-box-shadow: none;
111111
box-shadow: none;

js/widgets/controlgroup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ $.widget( "mobile.controlgroup", $.mobile.widget, $.extend( {
8282
},
8383

8484
refresh: function() {
85-
var $el = this.element,
85+
var $el = this.container(),
8686
els = $el.find( ".ui-btn" ).not( ".ui-slider-handle" ),
8787
create = this._initialRefresh;
8888
if ( $.mobile.checkboxradio ) {

0 commit comments

Comments
 (0)