[loader] Wrap functions bound to events in $.proxy at binding time, and pass then unwrapped at unbinding time

Gabriel Schulhof · Gabriel Schulhof · commit ad9adc31443a · 2012-10-04T15:43:27.000+03:00
diff --git a/js/widgets/loader.js b/js/widgets/loader.js
@@ -85,7 +85,7 @@ define( [ "jquery",	"../jquery.mobile.core", "../jquery.mobile.widget" ], functi
 				this.fakeFixLoader();
 				$window
 					.unbind( "scroll", this.checkLoaderPosition )
-					.bind( "scroll", this.fakeFixLoader );
+					.bind( "scroll", $.proxy( this.fakeFixLoader, this ) );
 			}
 		},
 
@@ -170,8 +170,8 @@ define( [ "jquery",	"../jquery.mobile.core", "../jquery.mobile.widget" ], functi
 				this.element.removeClass( "ui-loader-fakefix" );
 			}
 
-			$( window ).unbind( "scroll", $.proxy( this.fakeFixLoader, this) );
-			$( window ).unbind( "scroll", $.proxy( this.checkLoaderPosition, this ) );
+			$( window ).unbind( "scroll", this.fakeFixLoader );
+			$( window ).unbind( "scroll", this.checkLoaderPosition );
 		}
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ define( [ "jquery", "../jquery.mobile.core", "../jquery.mobile.widget" ], functi`
`85`	`85`	`this.fakeFixLoader();`
`86`	`86`	`$window`
`87`	`87`	`.unbind( "scroll", this.checkLoaderPosition )`
`88`		`- .bind( "scroll", this.fakeFixLoader );`
	`88`	`+ .bind( "scroll", $.proxy( this.fakeFixLoader, this ) );`
`89`	`89`	`}`
`90`	`90`	`},`
`91`	`91`
`@@ -170,8 +170,8 @@ define( [ "jquery", "../jquery.mobile.core", "../jquery.mobile.widget" ], functi`
`170`	`170`	`this.element.removeClass( "ui-loader-fakefix" );`
`171`	`171`	`}`
`172`	`172`
`173`		`- $( window ).unbind( "scroll", $.proxy( this.fakeFixLoader, this) );`
`174`		`- $( window ).unbind( "scroll", $.proxy( this.checkLoaderPosition, this ) );`
	`173`	`+ $( window ).unbind( "scroll", this.fakeFixLoader );`
	`174`	`+ $( window ).unbind( "scroll", this.checkLoaderPosition );`
`175`	`175`	`}`
`176`	`176`	`});`
`177`	`177`