Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit b90361b

Browse files
author
Gabriel Schulhof
committed
Slider: On Opera Mobile event.which is undefined. Accept that and get slidin'. Fixes #5903.
1 parent ab910d3 commit b90361b

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

js/widgets/forms/slider.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ $.widget( "mobile.slider", $.mobile.widget, $.extend( {
268268
_sliderVMouseDown: function( event ) {
269269
// NOTE: we don't do this in refresh because we still want to
270270
// support programmatic alteration of disabled inputs
271-
if ( this.options.disabled || !( event.which === 1 || event.which === 0 ) ) {
271+
if ( this.options.disabled || !( event.which === 1 || event.which === 0 || event.which === undefined ) ) {
272272
return false;
273273
}
274274
if ( this._trigger( "beforestart", event ) === false ) {

tests/unit/slider/slider_events.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@
375375
});
376376

377377
asyncTest( "drag should start only when clicked with left button", function(){
378-
expect( 4 );
378+
expect( 5 );
379379

380380
var control = $( "#mousedown-which-events" ),
381381
widget = control.data( "mobile-slider" ),
@@ -405,6 +405,15 @@
405405
function( result ) {
406406
deepEqual( result.slidestart.timedOut, false, "slider did emit 'slidestart' event upon left button press" );
407407
event = $.Event( "mousedown", { target: handle[ 0 ] } );
408+
event.which = undefined;
409+
slider.trigger( event );
410+
},
411+
{
412+
slidestart: { src: control, event: "slidestart" + eventNs + "1" }
413+
},
414+
function( result ) {
415+
deepEqual( result.slidestart.timedOut, false, "slider did emit 'slidestart' event upon undefined button press" );
416+
event = $.Event( "mousedown", { target: handle[ 0 ] } );
408417
event.which = 2;
409418
slider.trigger( event );
410419
},

0 commit comments

Comments
 (0)