Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit e306bb0

Browse files
author
Gabriel Schulhof
committed
Pagecontainer: "navigate" handlers: Turn off scrolling, then change page
Fixes gh-7148
1 parent f029237 commit e306bb0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

js/widgets/pagecontainer.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ define( [
2929
_create: function() {
3030
this.setLastScrollEnabled = true;
3131

32-
// TODO consider moving the navigation handler OUT of widget into
33-
// some other object as glue between the navigate event and the
34-
// content widget load and change methods
35-
this._on( this.window, { navigate: "_filterNavigateEvents" });
36-
3732
this._on( this.window, {
3833
// disable an scroll setting when a hashchange has been fired,
3934
// this only works because the recording of the scroll position
@@ -46,6 +41,11 @@ define( [
4641
scrollstop: "_delayedRecordScroll"
4742
});
4843

44+
// TODO consider moving the navigation handler OUT of widget into
45+
// some other object as glue between the navigate event and the
46+
// content widget load and change methods
47+
this._on( this.window, { navigate: "_filterNavigateEvents" });
48+
4949
// TODO move from page* events to content* events
5050
this._on({ pagechange: "_afterContentChange" });
5151

0 commit comments

Comments
 (0)