Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Commit fa2ccd1

Browse files
cgackGabriel Schulhof
authored andcommitted
Slider: value on button not updated
Closes gh-7289 Fixes gh-7137
1 parent 3c0378a commit fa2ccd1

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

js/widgets/forms/slider.tooltip.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,9 @@ $.widget( "mobile.slider", $.mobile.slider, {
9393
if ( o.popupEnabled && this._popup ) {
9494
this._positionPopup();
9595
this._popup.html( newValue );
96-
} else if ( o.showValue && !this.options.mini ) {
96+
}
97+
98+
if ( o.showValue && !this.options.mini ) {
9799
this.handle.html( newValue );
98100
}
99101
},

tests/unit/slider/index.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,10 @@
124124
<input type="range" name="tooltip-test" id="tooltip-test" value="17" min="0" max="100" data-nstest-popup-enabled="true"/>
125125
</label>
126126

127+
<label>Tooltip w/ Button value:
128+
<input type="range" name="tooltip-test-both" id="tooltip-test-both" value="17" min="0" max="100" data-nstest-popup-enabled="true" data-nstest-show-value="true"/>
129+
</label>
130+
127131
</div>
128132

129133
<div id="enhancetest">

tests/unit/slider/slider_core.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,4 +105,13 @@
105105
});
106106
slider.trigger( "mouseup" );
107107
});
108+
109+
test( "slider tooltip & button values should match after input value changes", function() {
110+
var slider = $("#tooltip-test-both");
111+
var sliderHandle = slider.siblings(".ui-slider-track").children(".ui-slider-handle");
112+
113+
slider.val( "9" ).blur();
114+
115+
ok( slider.val() === sliderHandle.text(), "slider text should match handle text");
116+
});
108117
})( jQuery );

0 commit comments

Comments
 (0)