Position: Handle sub-pixel offsets better in Firefox. Fixes #6000 - Position: Sometimes positioning is off by 1px in Firefox.

scottgonzalez · scottgonzalez · commit 32264f7ad126 · 2010-10-21T23:25:42.000-04:00
diff --git a/ui/jquery.ui.position.js b/ui/jquery.ui.position.js
@@ -122,8 +122,8 @@ $.fn.position = function( options ) {
 		}
 
 		// prevent fractions (see #5280)
-		position.left = parseInt( position.left );
-		position.top = parseInt( position.top );
+		position.left = Math.round( position.left );
+		position.top = Math.round( position.top );
 
 		collisionPosition = {
 			left: position.left - marginLeft,

Original file line number	Diff line number	Diff line change
`@@ -122,8 +122,8 @@ $.fn.position = function( options ) {`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`// prevent fractions (see #5280)`
`125`		`- position.left = parseInt( position.left );`
`126`		`- position.top = parseInt( position.top );`
	`125`	`+ position.left = Math.round( position.left );`
	`126`	`+ position.top = Math.round( position.top );`
`127`	`127`
`128`	`128`	`collisionPosition = {`
`129`	`129`	`left: position.left - marginLeft,`