Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly describe $ as an alias for jQuery #681

Closed
wants to merge 1 commit into from

Conversation

@AurelioDeRosa
Copy link
Member

@AurelioDeRosa AurelioDeRosa commented Oct 25, 2015

Fixes gh-680

@@ -53,6 +53,8 @@ $( document ).ready(function() {
});
```

<div class="warning">**Note**: The jQuery library exposes its methods and properties via two properties of the <code>window</code> object called <code>jQuery</code> and <code>$</code>. <code>$</code> is simply an alias for <code>jQuery</code> and it's often employed because it's shorter and faster to write.</div>

This comment has been minimized.

@arthurvr

arthurvr Oct 26, 2015
Member

Why should this be in a class="warning" box? Might as well just have a normal paragraph about this. The warnings always give me the feeling something is a gotcha or something could go wrong, but in this case it's just a concept being introduced.

This comment has been minimized.

@AurelioDeRosa

AurelioDeRosa Oct 26, 2015
Author Member

I feel it doesn't flow well with the rest of the discussion which has another focus, so I put it in a "aside" bar.

@agcolom

This comment has been minimized.

Copy link

@agcolom agcolom commented on c16682c Oct 28, 2015

LGTM

@AurelioDeRosa
Copy link
Member Author

@AurelioDeRosa AurelioDeRosa commented Oct 29, 2015

@agcolom should I merge it or should I address the comment of @arthurvr? I think it's fine as is but happy to update the PR:

@agcolom
Copy link
Member

@agcolom agcolom commented Oct 29, 2015

@AurelioDeRosa We could use either a normal note or a div class="note" which gives a blue box if I remember correctly.

@AurelioDeRosa
Copy link
Member Author

@AurelioDeRosa AurelioDeRosa commented Nov 15, 2015

@agcolom This is more of a general comment but I've checked the note class and it doesn't look very readable. I think the contrast isn't enough especially for <code>.

@agcolom
Copy link
Member

@agcolom agcolom commented Jan 21, 2016

@AurelioDeRosa I think you can land your PR :-)

@AurelioDeRosa
Copy link
Member Author

@AurelioDeRosa AurelioDeRosa commented Jan 21, 2016

Thank you for the review @agcolom. I'm going to merge it now.

@AurelioDeRosa AurelioDeRosa deleted the AurelioDeRosa:jquery-alias branch Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants