Skip to content

/jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-fire Callbacks report as initially locked #1989

Closed
gibson042 opened this issue Jan 4, 2015 · 0 comments

Comments

Assignees

@gibson042 gibson042

Labels
Bug Callbacks
Projects
None yet
Milestone
  1.12.0/2.2.0
3 participants
@gibson042 @dmethvin @markelog
@gibson042
Copy link
Member

commented Jan 4, 2015

http://jsfiddle.net/2d9gwd2c/

Note how the "once" flag breaks .locked().

In code, this assertion fails:

equal( jQuery.Callbacks("once").locked(), false );

@gibson042 gibson042 added the Callbacks label Jan 4, 2015

@gibson042 gibson042 self-assigned this Jan 4, 2015

@gibson042 gibson042 referenced this issue Jan 4, 2015

Closed

Callbacks: Update locking behavior #1991

@dmethvin dmethvin added this to the 3.0.0 milestone Jan 5, 2015

gibson042 added a commit that referenced this issue Jan 11, 2015

@gibson042
Callbacks: No object starts out locked 
Fixes gh-1989
f5a8c64

@gibson042 gibson042 closed this in 0d829f0 Jan 11, 2015

@markelog markelog added the Bug label Nov 10, 2015

gibson042 added a commit that referenced this issue Nov 10, 2015

@gibson042 @markelog
Callbacks: No object starts out locked 
Fixes gh-1989

(cherry picked from commit f5a8c64)
d407def

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.