Slider: Modified to allow value to reach max value with float step

Fixes #11286 Closes gh-1465
jquery · Mar 5, 2015 · 60c00cd4ecdab41f44e125efe2679223e9cd5535 · 60c00cd
1 parent af4c35d
commit 60c00cd4ecdab41f44e125efe2679223e9cd5535
Unified Split

Showing with 12 additions and 2 deletions.

+11 −1 tests/unit/slider/slider_methods.js

+1 −1 ui/slider.js
diff --git a/tests/unit/slider/slider_methods.js b/tests/unit/slider/slider_methods.js
@@ -62,7 +62,7 @@ test( "disable", function() {
 });
 
 test( "value", function() {
-	expect( 17 );
+	expect( 18 );
 	$( [ false, "min", "max" ] ).each(function() {
 		var element = $( "<div></div>" ).slider({
 			range: this,
@@ -88,6 +88,16 @@ test( "value", function() {
 	equal( element.slider( "value" ), 1, "value method get respects max" );
 	equal( element.slider( "value", 2 ), element, "value method is chainable" );
 	equal( element.slider( "option", "value" ), 1, "value method set respects max" );
+
+	// set max value with step 0.01
+	element.slider( "option", {
+		min: 2,
+		value: 2,
+		max: 2.4,
+		step: 0.01
+	});
+	element.slider( "option", "value", 2.4 );
+	equal( element.slider( "value" ), 2.4, "value is set to max with 0.01 step" );
 });
 
 //test( "values", function() {

diff --git a/ui/slider.js b/ui/slider.js
@@ -558,7 +558,7 @@ return $.widget( "ui.slider", $.ui.mouse, {
 		var max = this.options.max,
 			min = this._valueMin(),
 			step = this.options.step,
-			aboveMin = Math.floor( ( max - min ) / step ) * step;
+			aboveMin = Math.floor( ( +( max - min ).toFixed( this._precision() ) ) / step ) * step;
 		max = aboveMin + min;
 		this.max = parseFloat( max.toFixed( this._precision() ) );
 	},