#14282 closed bug (fixed)
Don't call getPreventDefault() if there is a defaultPrevented property
| Reported by: | dmethvin | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.11/2.1 |
| Component: | event | Version: | 1.10.2 |
| Keywords: | dbr | Cc: | |
| Blocked by: | Blocking: |
Description
Change History (20)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
OTH implementation using a getter would be larger so maybe it's better to use in in 2.x.
comment:3 Changed 4 years ago by
ES5 features tend to be slow, so the typeof check may be the best for both branches.
comment:5 Changed 4 years ago by
I agree on the ES5 case, though, especially that Android 2.3 devices aren't demons of speed.
comment:6 Changed 4 years ago by
| Component: | unfiled → event |
|---|---|
| Milestone: | None → 1.11/2.1 |
| Priority: | undecided → high |
| Status: | new → open |
Note to all who feel compelled to comment here: We are aware of the message, which is just a warning and has no effect on functionality. Do not post "me toos" or "when will this be fixed" here. It's scheduled to be fixed in the next release as shown in the status.
Note that even after the new vesion is released, older jQuery versions will continue to generate this message forever -- or until Chrome decides to remove the message.
comment:8 Changed 4 years ago by
| Owner: | set to dmethvin |
|---|---|
| Status: | open → assigned |
comment:9 Changed 4 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fix #14282. Don't fondle getPreventDefault if preventDefault exists. Close gh-1365.
Changeset: 4671ef15c2d62962048fd4863911146fcc085f26
comment:10 Changed 4 years ago by
I tested it with the 1.10.2 (as scheduled) release and i still get this message.
comment:12 Changed 4 years ago by
@dexter: please pay more attention next time, the bug was reported to exist exactly in the 1.10.2 you mentioned, it'll be fixed in 1.11. Beta is available.
comment:19 Changed 4 years ago by
| Keywords: | dbr added |
|---|
comment:25 Changed 3 years ago by
#14713 is a duplicate of this ticket. hussvampSvartmögelmögel i hus
comment:26 Changed 3 years ago by
#14600 is a duplicate of this ticket. rörinspektionFuktutredningmögel badrum

On 2.x we could probably implement
defaultPreventedusing an ES5 getter? 1.x requires typeof checks, unfortunately.