Test all factory use cases from intro.js #2181
Closed
Comments
|
We should do it before trying to fix #2177 so that it's easier to add a new test. |
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 26, 2015
There is a lot of logic in intro.js; now we test three cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. Fix jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 26, 2015
There is a lot of logic in intro.js; now we test three cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. Previously the second case was not tested and the third was tested in a way that interfered with the main test environment. Fix jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 26, 2015
There is a lot of logic in intro.js; now we test three cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. Previously the second case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fix jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 26, 2015
There is a lot of logic in intro.js; now we test three cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. Previously the second case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 27, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 27, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second & fourth case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 27, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second & fourth case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 27, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second & fourth case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 27, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second & fourth case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 27, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second & fourth case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
to mgol/jquery
that referenced
this issue
Apr 27, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second & fourth case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes jquerygh-2181
mgol
added a commit
that referenced
this issue
Nov 10, 2015
There is a lot of logic in intro.js; now we test four cases: 1. (implicitly, via QUnit tests) A real browser with window being the global 2. Browserify where there are both global & window variables. 3. Node with jsdom where window is passed manually to the jQuery factory. 4. Pure Node with incorrect window passed; jQuery should throw then. Previously the second & fourth case was not tested and the third was tested in a way that interfered with the main test environment. We now also test if in the Browserify case we're not creating a jQuery global by default. Fixes gh-2181 Closes gh-2234
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have a lot of logic in intro.js and we only test two: the browser use case and the most common Node+jsdom. We should cover all scenarios so that freely changing this code actually breaks some tests.
The text was updated successfully, but these errors were encountered: