Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow offset setter to throw when input is disconnected #2114

Closed
gibson042 opened this issue Mar 2, 2015 · 1 comment
Closed

Allow offset setter to throw when input is disconnected #2114

gibson042 opened this issue Mar 2, 2015 · 1 comment
Assignees
@timmywil
Labels
Behavior Change Offset
Milestone
3.0.0

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Mar 2, 2015

Fallout from #2043: #2043 (comment)

Remove the || { top: 0, left: 0 } that was added to let $disconnected.offset({ top: y, left: x }) continue proxying .css({ top: y, left: x }), along with any associated tests asserting the behavior.
@gibson042 gibson042 added this to the 3.0.0 milestone Mar 2, 2015
@gibson042 gibson042 mentioned this issue Mar 2, 2015
Closed
@gibson042 gibson042 mentioned this issue Mar 9, 2015
Closed
@timmywil timmywil self-assigned this May 5, 2015
@timmywil
Copy link
Member

@timmywil timmywil commented May 5, 2015

Just as a checkmark, this is already in the blog post.
@timmywil timmywil closed this in 0d11c11 May 5, 2015
timmywil added a commit that referenced this issue May 5, 2015
@timmywil
Offset: allow offset setter to throw for disconnected elements
Loading status checks…
dc49f62 
Fixes gh-2114
@markelog markelog mentioned this issue Nov 16, 2015
Closed
@markelog markelog mentioned this issue Dec 22, 2015
Closed
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Behavior Change Offset
Projects
None yet
Milestone
3.0.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@timmywil @gibson042