Opened 6 years ago
Closed 5 years ago
#10589 closed enhancement (fixed)
Remove $.fn.data("events")
| Reported by: | gnarf | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.8 |
| Component: | data | Version: | git |
| Keywords: | 1.8-discuss debug | Cc: | |
| Blocked by: | Blocking: |
Description (last modified by )
This was discussed when we talked about removing the .data("events") code. We would like to discourage/deprecate this usage, and perhaps release something like $.fn.events() to replace it in a "debugging extension".
I'd like to suggest that we deprecate the current usage as soon as possible.
Change History (14)
comment:1 Changed 6 years ago by
| Component: | unfiled → data |
|---|---|
| Keywords: | 1.8-discuss debug added |
| Milestone: | None → 1.8 |
| Status: | new → open |
comment:2 Changed 6 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 6 years ago by
comment:4 Changed 6 years ago by
Thought I just had - what about maintaining a list of bound handlers on the element's event fn?
Something like el.keydown.getHandlers() returns [ function() { ... }, $.noop, somefunc ]
comment:5 Changed 6 years ago by
| Priority: | undecided → high |
|---|
comment:6 Changed 6 years ago by
Given that I changed some of the internal structure of the events object during 1.7, several of the plugins that dig into the information in detail don't work properly anyway. I didn't realize this until we started the discussion yesterday and some people joined that thread. However, I have yet to be convinced that the people using "events" that way should be using them.
https://github.com/jquery/jquery/commit/24e416dca36df4b182a612dba37f8b6cdaa25916
The data isn't being hidden, just moved to its rightful place in the internal data object so that user data named "events" won't clobber it. So we aren't preventing anyone from being able to inspect events for debugging purposes, which seems to be the most common need.
Once we come to a resolution on this and other 1.8 initiatives I'd suggest a blog post with the results so we can prepare people for the move from jQuery(elem, "events") to jQuery._data(elem, "events") with the warning that it is not a public interface and subject to change.
comment:9 Changed 6 years ago by
| Description: | modified (diff) |
|---|
+1, For access, let's stay with jQuery._data(elem, "events") so people understand it's not a documented interface.
comment:13 Changed 5 years ago by
| Owner: | set to dmethvin |
|---|---|
| Status: | open → assigned |
| Summary: | Deprecate $.fn.data("events") - Replace with debugging extension → Remove $.fn.data("events") |
Per the blog entry: http://blog.jquery.com/2011/11/08/building-a-slimmer-jquery/
comment:14 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fix #10589. Remove deprecated $.fn.data("events") special case.
No unit tests were harmed in the removal of this hack.
Changeset: 9e0c056171d1a5cac407f8fedbf926be91eaba1a

I use it for debugging, or at times for re-ordering already bound events if I need to bind something but have it fire first like this:
el.data( 'events' ).keydown.unshift( el.data( 'events' ).keydown.pop() );