Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
$.holdReady is broken in 3.2.0 #3573
Comments
mgol
added this to the 3.2.1 milestone
Mar 17, 2017
mgol
added
Blocker
Core
Bug
labels
Mar 17, 2017
|
It was moved erroneously to Thanks for the report! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
mgol
Mar 17, 2017
Member
This only shows we should have explicit tests for any API that we deprecate, even if there weren't any due to legacy reasons.
|
This only shows we should have explicit tests for any API that we deprecate, even if there weren't any due to legacy reasons. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
timmywil
Mar 17, 2017
Member
Oof. How did we not catch this?
By the way, temporary workaround:
jQuery.holdReady = jQuery.fn.holdReady;|
Oof. How did we not catch this? By the way, temporary workaround: jQuery.holdReady = jQuery.fn.holdReady; |
|
I think making the necessary adjustments to this PR and landing it will give us the test coverage we want for this issue. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Krinkle
Mar 17, 2017
Member
It had been failing for several weeks in Jenkins/TestSwarm:
http://swarm.jquery.org/project/jquerymigrate
Core commit (17 February):
- bd984f0 Core: Move holdReady to deprecated
|
It had been failing for several weeks in Jenkins/TestSwarm: Core commit (17 February):
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
timmywil
Mar 17, 2017
Member
Well, that's jQuery migrate, not jQuery core, but I'm surprised no one said anything.
|
Well, that's jQuery migrate, not jQuery core, but I'm surprised no one said anything. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
mgol
Mar 18, 2017
Member
|
Perhaps looking at Migrate test results should be added to the release
instructions in our Wiki. Currently only regular Core & periodic test
results are mentioned.
--
Michał Gołębiowski
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
timmywil
Mar 18, 2017
Member
This seems like a rare case, and it will be fixed when we land the PR I mentioned. I would like to ensure that reviewing core tests is sufficient for releasing core and reviewing migrate tests sufficient for migrate.
|
This seems like a rare case, and it will be fixed when we land the PR I mentioned. I would like to ensure that reviewing core tests is sufficient for releasing core and reviewing migrate tests sufficient for migrate. |


San4es commentedMar 17, 2017
The "$.holdReady is not a function" error occurs after the update to jQuery 3.2.0.
To reproduce the issue, see https://jsfiddle.net/4ocpkd69/ (see browser console) and compare results with jQuery 3.1.1 in https://jsfiddle.net/4ocpkd69/1/