Seems fulfilled with Array.isArray

👍

agreed

I guess it's worth moving Array.isArray into /var and re-use:

   raw     gz Compared to master @ 44cb97e0cfc8d3e62bef7c621bfeba6fe4f65d7c    
  +601   +147 dist/jquery.js                                                   
   -60    -12 dist/jquery.min.js

Nice find, but with this ticket we would need to move it to deprecated.js module

That's a calculation with the following code in deprecated.js:

jQuery.extend( {
    isArray: isArray
} );

You mean gzip size will also change in identical manner if we move it to deprecated.js as if we moved it to /var?

That's the result of having both /var file creation for storing variable and moving declaration to deprecated.js.

Deprecation would mean that we:

1. Move jQuery.isArray to deprecated.js
2. Change all internal uses from jQuery.isArray to Array.isArray

so we can't have the var-module containing the old code here.

Right, but as other built-in methods (slice, concat, toString etc) isArray could be stored in /var.

So you propose to put Array.isArray in a var-module, not jQuery.isArray? I understood it differently before.

That's right. Sorry for not explaining that before.

I wouldn't want size to influence our file hierarchy, it would be pretty confusing, also all deprecated modules should be stored in deprecated module, since it would also be confusing but now for users too who want to exclude or use deprecated stuff

@markelog I agree to an extent but @FarSeeing only proposes to put Array.isArray in a var-module, not the soon-to-be-deprecated jQuery.isArray; see our last 2 comments.

Oh, i see, but i wouldn't do that too :), don't really see the point

Guys, is there a possibility of me submitting a PR for this?

@ShashankaNataraj Sure! Do you know what needs to be done?

I would wait until we would have discussion about this, it seems some team members feel "deprecation" process of core methods might be inappropriate.

@mgol @markelog Correct me if Im wrong, tasks for this issue are:

• Move jquery.isArray to deprecated.js
• Change all usages of jQuery.isArray to Array.isArray

Also, the third item - its unit tests have to be moved to jQuery.isArray as
well.

Also, if this hasn't been mentioned before - each deprecation, apart from a
jQuery PR and an API site issue needs a jQuery Migrate issue to polyfill
the API and warn against using it.

Michał Gołębiowski

@mgol Didnt get what you meant by

its unit tests have to be moved to jQuery.isArray as well.

I understand unit tests need to be modified but jQuery.isArray tests need to be removed right?

Actually I have been raising issues like this for every deprecation issue Im working on..

Raised one for this issue too.

I understand unit tests need to be modified but jQuery.isArray tests need to be removed right?

Not removed but moved to test/unit/deprecated.js.

Actually I have been raising issues like this for every deprecation issue Im working on..

I've seen them, thanks for that! I meant that apart from the API issue we also need an issue at https://github.com/jquery/jquery-migrate/issues about a need to restore the API (because people may exclude the deprecated module) with a warning against using it.

@ShashankaNataraj seems not to be working on this. Can I please take this ?

Correct me, for any changes

• Move jquery.isArray to deprecated.js
• Change all usages of jQuery.isArray to Array.isArray
• Modify unit tests
• Create a jquery-migrate issue for jQuery.isArray