/jquery

New issue

`jQuery.Event( src )` cannot require `src.target` #3139

Closed
dmethvin opened this Issue Jun 2, 2016 · 2 comments

Assignees

@dmethvin dmethvin

Labels

Bug Event Has Pull Request

Projects

None yet

Milestone

  3.0.0

3 participants

@dmethvin @arschmitz @mgol
@dmethvin
Member
dmethvin commented Jun 2, 2016

If you construct a jQuery.Event( src ) using something that has src.type, the 3.0 code will die if there is not an src.target property. jQuery Mobile uses a pattern where they construct an object and then set properties like target afterwards, which was allowed by 1.x/2.x, so we need to fix this as a regression.
@dmethvin dmethvin added this to the 3.0.0 milestone Jun 2, 2016
@dmethvin dmethvin self-assigned this Jun 2, 2016
@dmethvin
Member
dmethvin commented Jun 2, 2016

/cc @arschmitz
@dmethvin dmethvin added a commit to dmethvin/jquery that referenced this issue Jun 2, 2016
@dmethvin dmethvin Event: Allow constructing a jQuery.Event without a target 
Fixes gh-3139
 cd7d817
@dmethvin dmethvin referenced this issue Jun 2, 2016
Closed

Event: Allow constructing a jQuery.Event without a target #3140

4 of 4 tasks complete
@arschmitz
Member
arschmitz commented Jun 2, 2016

@dmethvin ah thanks yeah i was having trouble figuring out exactly where this error was coming from
@dmethvin dmethvin added a commit that closed this issue Jun 3, 2016
@dmethvin dmethvin Event: Allow constructing a jQuery.Event without a target 
Fixes gh-3139
Closes gh-3140
 2df590e
@dmethvin dmethvin closed this in 2df590e Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment