IE 8 clears the expando instead of setting it to undefined #2596

mgol · 2015-09-14T17:01:09Z

The following test fails on IE 8 and only there:

Lines 2728 to 2750 in fc87a5c

    
           QUnit.test( ".off() removes the expando when there's no more data", function( assert ) { 
        
           	assert.expect( 2 ); 
        
           	var key, 
        
           		div = jQuery( "<div/>" ).appendTo( "#qunit-fixture" ); 
        
           	div.on( "click", false ); 
        
           	div.on( "custom", function() { 
        
           		assert.ok( true, "Custom event triggered" ); 
        
           	} ); 
        
           	div.trigger( "custom" ); 
        
           	div.off( "click custom" ); 
        
           	// Make sure the expando is gone 
        
           	for ( key in div[ 0 ] ) { 
        
           		if ( /^jQuery/.test( key ) ) { 
        
           			assert.strictEqual( 
        
           				div[ 0 ][ key ], undefined, 
        
           				"Expando was not removed when there was no more data" 
        
           			); 
        
           		} 
        
           	} 
        
           } );

IE 8 gets the expando removed via removeAttribute so the second assertion won't be reached. The expected assertion count had to be updated. Fixes gh-2596

mgol · 2015-09-14T18:28:31Z

Fixed in 4b1cff6

mgol added the Event label Sep 14, 2015

mgol added this to the 3.0.0 milestone Sep 14, 2015

mgol self-assigned this Sep 14, 2015

mgol closed this Sep 14, 2015

dmethvin added this to the 1.12/2.2 milestone Jan 8, 2016

dmethvin removed this from the 3.0.0 milestone Jan 8, 2016

cssmagic mentioned this issue May 18, 2016

jQuery cssmagic/ChangeLog#5

Open

lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

jquery / jquery

IE 8 clears the expando instead of setting it to undefined #2596

IE 8 clears the expando instead of setting it to undefined #2596

mgol commented Sep 14, 2015

mgol commented Sep 14, 2015

jquery / jquery

IE 8 clears the expando instead of setting it to undefined #2596

IE 8 clears the expando instead of setting it to undefined #2596

Comments

mgol commented Sep 14, 2015

mgol commented Sep 14, 2015