Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove package-lock.json? #3792
Comments
mgol
added
Build
Needs review
labels
Sep 20, 2017
mgol
changed the title from
Remove package-lock.json
to
Remove package-lock.json?
Sep 20, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
timmywil
Sep 20, 2017
Member
hmm, it shouldn't regenerate the lockfile. Otherwise, what's the point of a lockfile? Has this been reported to npm?
|
hmm, it shouldn't regenerate the lockfile. Otherwise, what's the point of a lockfile? Has this been reported to npm? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
mgol
Sep 20, 2017
Member
It seems to be npm/npm#18135, open since August 10. No feedback from the npm team so far.
|
It seems to be npm/npm#18135, open since August 10. No feedback from the npm team so far. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
dmethvin
Sep 20, 2017
Member
Interesting that yarn does install everything and has an opposite problem: yarnpkg/yarn#4190
|
Interesting that |
mgol commentedSep 20, 2017
Description
npm 5, even the version included in the latest Node.js 8.5.0 re-generates
package-lock.jsonon each install. And when it does on a system that doesn't support all the optional dependencies that are supported on the OS where the lockfile was generated, it removes those optional deps from the lockfile.The effect is that everyone firing
npm installon our repo on any OS other than macOS will immediately get a dirty state of the repo as thefseventsdependency subtree gets removed frompackage-lock.json. That's a really bad experience.Link to test case