Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose jQuery.access #2513

Closed
mgol opened this issue Jul 31, 2015 · 3 comments
Closed

Don't expose jQuery.access #2513

mgol opened this issue Jul 31, 2015 · 3 comments
Assignees
@mgol
Labels
Core
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

@mgol mgol commented Jul 31, 2015

jQuery.access is public & undocumented, is there a reason we should keep it that way? We removed jQuery.swap (#2058), jQuery.buildFragment (#2224) & jQuery.domManip (#2225).

See also #2512.
@mgol mgol mentioned this issue Jul 31, 2015
Closed
@mgol mgol added this to the 3.0.0 milestone Aug 3, 2015
@mgol mgol self-assigned this Aug 3, 2015
@mgol mgol removed the Needs review label Aug 3, 2015
mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015
@mgol
Core: Don't expose jQuery.access
5e926fc 
jQuery.access was never documented, there is no need to keep it exposed.

Fixes jquerygh-2513
@mgol mgol mentioned this issue Aug 3, 2015
Merged
mgol added a commit to mgol/jquery that referenced this issue Aug 3, 2015
@mgol
Core: Don't expose jQuery.access
9adfad1 
jQuery.access was never documented, there is no need to keep it exposed.

Fixes jquerygh-2513
Closes jquerygh-2524
@mgol
Copy link
Member Author

@mgol mgol commented Aug 3, 2015

PR: #2524
@mgol mgol closed this in #2524 Aug 4, 2015
mgol added a commit that referenced this issue Aug 4, 2015
@mgol
Core: Don't expose jQuery.access
Loading status checks…
12230d3 
jQuery.access was never documented, there is no need to keep it exposed.

Fixes gh-2513
Closes gh-2524
riichard added a commit to riichard/jquery that referenced this issue Sep 20, 2015
@mgol @riichard
Core: Don't expose jQuery.access
c81b984 
jQuery.access was never documented, there is no need to keep it exposed.

Fixes jquerygh-2513
Closes jquerygh-2524
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 8, 2016
@milesj
Copy link

@milesj milesj commented Apr 20, 2016

This was unfortunate. $.access() was great for building our own getter/setter combo methods.
@milesj milesj mentioned this issue Apr 20, 2016
Closed
@timmywil
Copy link
Member

@timmywil timmywil commented Apr 20, 2016

Sorry for the inconvenience! I'd be willing to consider exposing this method (and documenting it) for plugins, but we don't like having public methods that aren't documented.
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Core
Projects
None yet
Milestone
1.12.0/2.2.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@milesj @dmethvin @timmywil @mgol