Build: Only run browser tests in one Node version on Travis #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
Dec 18, 2017
.travis.yml
Outdated
| - node_js: "8" | ||
| env: NPM_SCRIPT=test | ||
| script: | ||
| - npm run-script $NPM_SCRIPT |
There was a problem hiding this comment.
Might want to use npm run here for consistency with the other callers.
Krinkle
approved these changes
Dec 18, 2017
|
@Krinkle I modified it as some tests were running twice. Now all Nodes run browserless tests and - in addition to that - one Node runs browser tests only. PTAL. |
|
@mgol Yep, makes sense. Also cuts down total time for Travis CI from 13 min to 9 min. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Ref gh-3744
Summary
Only run browser tests in one Node version on Travis. This reduces the possibility of failure.
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com