CSS: Drop the float mapping from cssProps #3569
Merged
Conversation
Firefox 35 and newer support style.float directly.
|
@mgol, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dmethvin, @markelog and @mikesherov to be potential reviewers. |
|
@mgol Were you thinking you'd like to get this into 3.2? |
|
It was done only for firefox? Good catch then! I think we should deprecate it if that's the case |
|
@timmywil It doesn't matter; if it got enough LGTMs then fine but if not it may wait. It doesn't cause any observable difference for jQuery users.
For Firefox but in jQuery 1.x also for IE <9 as they use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
Firefox 35 and newer support
style.floatdirectly so we don't have to mapfloattocssFloatany more.Maybe we could deprecate
jQuery.cssProps? It's not documented and we now removed its last reason to exist from the Core point of view.Checklist
Mark an
[x]for completed items, if you're not sure leave them unchecked and we can assist.New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.comThanks! Bots and humans will be around shortly to check it out.