/jquery

New issue

jQuery leaks detached DOM #3018

Closed
jakwuh opened this Issue Mar 26, 2016 · 1 comment

Assignees

@markelog markelog

Labels

Has Pull Request Support

Projects

None yet

Milestone

  3.0.0

3 participants

@jakwuh @markelog @timmywil
@jakwuh
jakwuh commented Mar 26, 2016

I've noticed that in css/support.js there is a created DOM element, which is referenced then in function computeStyleTests. Because of it this DOM will never be removed.
Is it the way as it should be?
@markelog
Member
markelog commented Mar 28, 2016

Hardly a "leak", but yeah, this could be improved.
@markelog markelog added the Support label Mar 28, 2016
@markelog markelog added a commit to markelog/jquery that referenced this issue Mar 28, 2016
@markelog markelog Support: improve support properties computation 
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes gh-3018
 b84fd61
@markelog markelog added a commit to markelog/jquery that referenced this issue Mar 28, 2016
@markelog markelog Support: improve support properties computation 
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes gh-3018
 0465e69
@timmywil timmywil added this to the 3.0.0 milestone Mar 28, 2016
@markelog markelog was assigned by timmywil Mar 28, 2016
@markelog markelog added a commit that closed this issue Mar 28, 2016
@markelog markelog Support: improve support properties computation 
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes gh-3018
Closes gh-3021
 44cb97e
@markelog markelog closed this in 44cb97e Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment