Skip to content

/jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirejs dep when available #2290

Closed
markelog opened this issue May 9, 2015 · 5 comments

Comments

Assignees

@markelog markelog

Labels
Build
Projects
None yet
Milestone
No milestone
3 participants
@markelog @mgol @timmywil
@markelog
Copy link
Member

commented May 9, 2015

Now it causes small issue with build version, but it has a danger of breaking things in the future, we should be aware of this issue and update "requirejs" accordingly

Example, from

// Support: Firefox 18+
// Can't be in strict mode, several libs including ASP.NET trace
// the stack via arguments.caller.callee and Firefox dies if
// you try to trace through "use strict" call chains. (#13335)
//"use strict";

to

// Support: Firefox 18+
// Can't be in strict mode, several libs including ASP.NET trace
// the stack via arguments.caller.callee and Firefox dies if
// you try to trace through "use strict" call chains. (#13335)
//

Fix should have been ladnded in 2.1.17 but i still see the incorrect output.

Ref requirejs/r.js#689
/cc @jrburke

@markelog markelog added the Build label May 9, 2015

@markelog markelog changed the title Update requirejs dep when avaliable Update requirejs dep when available May 9, 2015

@mgol

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 9, 2015

This is just a comment so it's not terribly important.
@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 11, 2015

I think all we need here is a comment saying r.js will strip "use strict"; if added.
@markelog

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented May 11, 2015

This is just a comment so it's not terribly important.

It might confuse people who would check out build source

I think all we need here is a comment saying r.js will strip "use strict"; if added.

That sounds awkward :-(.

This issue might cause real failures, this ticket is created so we would be aware of it and fix it when appropriate fix will be landed.
@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 11, 2015

I'd rather not leave issues lying around as reminders. We can cross that
bridge if/when we come to it.
On Mon, May 11, 2015 at 10:41 Oleg Gaidarenko notifications@github.com
wrote:

This is just a comment so it's not terribly important.

It might confuse people who would check out build source

I think all we need here is a comment saying r.js will strip "use strict";
if added.

That sounds awkward :-(.

This issue might cause real failures, this ticket is created so we would
be aware of it and fix it when appropriate fix will be landed.

—
Reply to this email directly or view it on GitHub
#2290 (comment).
@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 11, 2015

Ok, I misunderstood the issue. I thought that latest requirejs would strip the "use strict". Since the action item is just to update requirejs, I'm all for that.

@markelog markelog self-assigned this May 11, 2015

@markelog markelog closed this in a644101 May 19, 2015

markelog added a commit that referenced this issue May 19, 2015

@markelog
Build: update requirejs dependency to 2.1.17 
Fixes gh-2290
Ref a644101
Loading status checks…
a9296df

markelog added a commit that referenced this issue Nov 10, 2015

@markelog
Build: update requirejs dependency to 2.1.17 
Fixes gh-2290
02dd501

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.