Bug Tracker

Opened 6 years ago

Closed 6 years ago

#9147 closed bug (fixed)

Variable tmp in promise implicitly declared?

Reported by: johnwilander Owned by:
Priority: blocker Milestone: 1.6.1
Component: queue Version: 1.6
Keywords: Cc:
Blocked by: Blocking:

Description

It seems the variable tmp in promise is implicitly declared (jquery-1.6.js line 1861). If you enter "use strict"; in the beginning of the file that variable becomes a strict mode violation.

In unminified code:

if (( tmp = jQuery.data( elements[ i ], deferDataKey, undefined, true )

In minified code:

while (g--)if (tmp = f.data(e[g], i, b, !0)

Regards, John Wilander

Change History (3)

comment:1 Changed 6 years ago by timmywil

Component: unfiled → queue
Milestone: 1.next → 1.6.1
Priority: undecided → blocker
Status: new → open

Thanks! I think you're right. L158 of queue.js

comment:2 Changed 6 years ago by jaubourg

Oh! The shameful moment :/

Thanks for having caught this one John.

comment:3 Changed 6 years ago by timmywil

Resolution: → fixed
Status: open → closed

tmp was global in the new fn.promise. Fixes #9147.

Changeset: f7f8450041df7c250f04b03cbbcbd2d01025f379

Note: See TracTickets for help on using tickets.