Skip to content

/jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Error in Sizzle version check #1939

Closed
dmethvin opened this issue Dec 17, 2014 · 6 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  1.12.0/2.2.0
2 participants
@dmethvin @timmywil
@dmethvin
Copy link
Member

commented Dec 17, 2014

Dies during the check, not sure why. I just backed out 1d93106 fon 1.11-stable and 2.1-stable, but we'll need to to the same or fix it before 3.0 in both master and compat.

Checking Sizzle version...

/var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/node_modules/q/q.js:126
                    throw e;
                          ^
TypeError: Arguments to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at GitHubResolver._checkout (/var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/lib/core/resolvers/GitHubResolver.js:54:21)
    at /var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/lib/core/resolvers/GitResolver.js:69:21
    at _fulfilled (/var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/node_modules/q/q.js:798:54)
    at self.promiseDispatch.done (/var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/node_modules/q/q.js:827:30)
    at Promise.promise.promiseDispatch (/var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/node_modules/q/q.js:760:13)
    at /var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/node_modules/q/q.js:574:44
    at flush (/var/www/jquery-release/__release/repo/node_modules/grunt-bowercopy/node_modules/bower/node_modules/q/q.js:108:17)

@dmethvin dmethvin added this to the 3.0.0 milestone Dec 17, 2014

@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 17, 2014

I don't think it likes the version number. However, I'm not sure you'll encounter the same problem on master/compat since we dropped bower.
@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 17, 2014

Oh, I understand. You won't encounter this problem on master/compat because the Sizzle version there is not funky.
@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 17, 2014

rversion didn't match so it's passing null. I'll do a fix, but it won't matter.
@dmethvin

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 17, 2014

If that occurs would it be considered an error?
@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 17, 2014

I suppose it would be right now, but it might not be in the future.
@timmywil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 17, 2014

That is, if we were to publish a version of Sizzle to npm that does not exactly fit the format of x.x.x-optionalWord.

@timmywil timmywil closed this in 78ac753 Dec 17, 2014

timmywil added a commit that referenced this issue Dec 17, 2014

@timmywil
Build: account for version labels in Sizzle versions 
Fixes gh-1939
ac70dd0

timmywil added a commit that referenced this issue Nov 10, 2015

@timmywil @markelog
Build: account for version labels in Sizzle versions 
Fixes gh-1939
343e583

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.