Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ownerDocument check in offset getter #2115

Closed
gibson042 opened this issue Mar 2, 2015 · 2 comments
Closed

Remove ownerDocument check in offset getter #2115

gibson042 opened this issue Mar 2, 2015 · 2 comments
Assignees
@timmywil
Labels
Behavior Change Offset
Milestone
3.0.0

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Mar 2, 2015

Fallout from #2043: https://github.com/jquery/jquery/pull/2043/files#r23981494

Since all supported browsers have getBoundingClientRect, there's no reason not to just call the method right away, letting an exception throw if input is in fact not a DOM element.

The "object without getBoundingClientRect" test will have to go as well.
@gibson042 gibson042 added this to the 3.0.0 milestone Mar 2, 2015
@gibson042 gibson042 mentioned this issue Mar 2, 2015
Closed
@gibson042 gibson042 changed the title Remove document check in offset getter Remove ownerDocument check in offset getter Mar 2, 2015
@dmethvin
Copy link
Member

@dmethvin dmethvin commented Mar 3, 2015

According to #12536 we had that guard in for browsers we no longer support, so that sounds good to me.
@gibson042 gibson042 mentioned this issue Mar 9, 2015
Closed
@mgol
Copy link
Member

@mgol mgol commented Apr 26, 2015

Yes, we already have a couple of places where we stopped guarding against browsers with missing getBoundingClientRect so this one should go as well.
@timmywil timmywil self-assigned this May 5, 2015
@timmywil timmywil closed this in 6176567 May 5, 2015
timmywil added a commit that referenced this issue May 5, 2015
@timmywil
Offset: remove ownerDocument check in offset getter
a2386a8 
Fixes gh-2115
@markelog markelog mentioned this issue Nov 16, 2015
Closed
@markelog markelog mentioned this issue Dec 22, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Behavior Change Offset
Projects
None yet
Milestone
3.0.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@dmethvin @timmywil @gibson042 @mgol