Skip to content

/jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get mouse position in dragover event #1925

Closed
ocerman opened this issue Dec 14, 2014 · 6 comments

Comments

Assignees

@dmethvin dmethvin

Labels
Bug Event
Projects
None yet
Milestone
  1.12.0/2.2.0
5 participants
@ocerman @araghava @dmethvin @markelog @gtristan
@ocerman
Copy link

commented Dec 14, 2014

I cannot get mouse position via e.pageX and e.pageY in dragover event in recent version of jQuery.
However, same code is working in jQuery 1.6.4

Example code: http://jsfiddle.net/blacksvk/qnbc80xy/1/

@markelog markelog added the Event label Dec 18, 2014

@araghava

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Dec 20, 2014

The regex here does not include drag events, which prevents the properties such as pageX and pageY from being coped over here.

Modifying the regex to:

rmouseEvent = /^(?:mouse|pointer|contextmenu|drag)|click/,

might be a potential fix?
@dmethvin

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 23, 2014

I agree this would be an easy fix to get mouse-related properties since DragEvent inherits from MouseEvent. In general we do not support the HTML5 drag/drop special properties directly and you should use event.originalEvent for that, see the discussion in Trac #7808.

@dmethvin dmethvin added this to the 3.0.0 milestone Dec 23, 2014

@dmethvin dmethvin added Feature Bug and removed Feature labels Dec 23, 2014

@markelog

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 23, 2014

So @araghava, @blacksvk would any of you like to send us a PR for it?
@araghava

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Dec 24, 2014

@markelog i'll have a look shortly

araghava added a commit to araghava/jquery that referenced this issue Dec 27, 2014

@araghava
Event: fixing pageX/pageY mouse information in drag events 
Fixes jquerygh-1925
b5ec04b

@araghava araghava referenced this issue Dec 27, 2014

Closed

Event: fixing pageX/pageY mouse information in drag events #1977

araghava added a commit to araghava/jquery that referenced this issue Dec 27, 2014

@araghava
Event: fixing pageX/pageY mouse information in drag events 
Fixes jquerygh-1925
939725a

araghava added a commit to araghava/jquery that referenced this issue Dec 27, 2014

@araghava
Event: fixing pageX/pageY mouse information in drag events 
Fixes jquerygh-1925
42b1d09

araghava added a commit to araghava/jquery that referenced this issue Dec 27, 2014

@araghava
Event: fixing pageX/pageY mouse information in drag events 
Fixes jquerygh-1925
1f62510

@dmethvin dmethvin self-assigned this Jan 5, 2015

dmethvin added a commit that referenced this issue Jan 5, 2015

@araghava @dmethvin
Event: Normalize mouse event properties in drag events 
DragEvent is a superset of MouseEvent, so we want to fix up mouse
properties like pageX and pageY.

Fixes gh-1925
(cherry picked from commit 389b2ab3b93bfd68ca6c6153a43e11d93ab9ec71)
Loading status checks…
5b0b1b7

@dmethvin dmethvin closed this in 97cf528 Jan 5, 2015

@gtristan

This comment has been minimized.

Sign in to view
Copy link

commented Jan 13, 2015

The above patch fixes dragstart,drag,dragend,dragover,dragenter and dragleave

However it does not fix the drop event.

I admit to not being a regexpert, but this adjustment fixes it for me:

rmouseEvent = /^(?:mouse|pointer|contextmenu|drag)|drop|click/,

@dmethvin dmethvin referenced this issue Jan 13, 2015

Closed

The drop event is a DragEvent as well #2009

@dmethvin

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 13, 2015

@gtristan thanks for the note, new issue has been created

dmethvin added a commit that referenced this issue Jan 14, 2015

@dmethvin
Event: HTML5 drop events inherit from MouseEvent 
Fixes gh-2009
Ref gh-1925
(cherry picked from commit d7e5fce)

Conflicts:
	test/unit/event.js
Loading status checks…
a05de40

dmethvin added a commit that referenced this issue Jan 14, 2015

@dmethvin
Event: HTML5 drop events inherit from MouseEvent 
Fixes gh-2009
Ref gh-1925
Loading status checks…
d7e5fce

markelog added a commit that referenced this issue Nov 10, 2015

@araghava @markelog
Event: Normalize mouse event properties in drag events 
DragEvent is a superset of MouseEvent, so we want to fix up mouse
properties like pageX and pageY.

Fixes gh-1925
fd85fd9

dmethvin added a commit that referenced this issue Nov 10, 2015

@dmethvin @markelog
Event: HTML5 drop events inherit from MouseEvent 
Fixes gh-2009
Ref gh-1925
6633261

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.