Description

It would be great if these examples:

var class1 = 'class-one';
var class2 = 'class-two';

$('.element').addClass(class1 + ' ' + class2);
$('.element').addClass(class1).addClass(class2);
$('.element').addClass([class1, class2].join(' '));

could instead be written like:

var class1 = 'class-one';
var class2 = 'class-two';

$('.element').addClass([class1, class2]);

For the most part, we're not looking to add signatures or new features to jQuery, but I don't hate this. It has parity with libraries like React and Angular.

Note that this can already be done by $('.element').addClass([class1, class2].join(" ")); which isn't that burdensome. It will take more bytes than that to do this inside jQuery.

@dmethvin

Note that this can already be done by $('.element').addClass([class1, class2].join(" ")); which isn't that burdensome. It will take more bytes than that to do this inside jQuery.

It's true but it's also uglier. :)

I like this proposal because:

1. We don't currently accept arrays as any parameter to class methods so there should be no confusion. Because of that, it shouldn't also add that much code to jQuery.
2. Accepting classes will align us more with the classList standard and aligning with standards is A Good Thing.
3. It will allow to pass unprocessed class arrays to jQuery from other libraries/frameworks that use the array syntax.
4. (This one is a bit of a stretch, but...) If we ever drop IE and start using classList instead of classNames everywhere, this would be a more natural signature and the space-separated values would be the ones that requires more pre-processing.

I'd like to contribute and get this one! 😃
What do you think, @timmywil?

Hi @timmywil, is this already assigned to someone ? I want to take this up.

Hi @timmywil, I want to take this up.

Should this add support for arrays (addClass(["a", "b"])) or multiple arguments (addClass("a", "b")), or both? The multiple arguments one is more like the classList methods so that would be my vote.

Multiple arguments might conflict with .toggleClass()'s second boolean argument 🤔

Seems like classList.toggle doesn't support multiple classes, only add/remove support it. I still vote to do the same as classList and don't support it with toggleClass...

@jbedard We've discussed it already (you were present :)), accepting positional parameters would require way more code and would align worse with the standard because of funkiness like .addClass('a b c', 'd'); the discussion can be seen at https://gitter.im/jquery/meeting/archives/2017/02/06.

That was a long time ago! That info should be put in this ticket for those wanting to pick it up...

If no one has worked on it, can I take a stab at it?

Anyone who would like to submit a PR for this, please feel free. Our contributing guidelines should answer any questions you might have about contributing to jQuery. Specifically, I suggest having a look at the Commits and PR guidelines and JS style guide.

Working on it.