/jquery

New issue

Deprecate jQuery.nodeName, remove in 4.0 #3475

Closed
mgol opened this Issue Dec 27, 2016 · 9 comments

Comments

Assignees

@mgol mgol

Labels
Behavior Change Core Has Pull Request
Projects
None yet
Milestone
  3.2.0
4 participants
@mgol @timmywil @karan-96 @dmethvin
@mgol
Member

mgol commented Dec 27, 2016

Description

jQuery.nodeName is another undocumented utility function that's exposed on the jQuery object. We should remove it (probably in 4.0 as it's been there for a long time).

Link to test case

https://jsfiddle.net/o648k3ga/1/

@mgol mgol added Behavior Change Core Needs review labels Dec 27, 2016

mgol added this to the 4.0.0 milestone Dec 27, 2016

@timmywil
Owner

timmywil commented Dec 27, 2016

If we want to remove it in 4.0, we should deprecate in 3.2.
@mgol
Member

mgol commented Dec 27, 2016

We can't deprecate something that's not documented. :) It's more than deprecated.
@timmywil
Owner

timmywil commented Dec 27, 2016 • edited

@mgol I'd still like to give notice. We're doing the same for other undocumented functions that we plan on removing. While not required, you might call it courteous.

timmywil removed the Needs review label Jan 9, 2017

@timmywil timmywil modified the milestone: 3.2.0, 4.0.0 Jan 9, 2017

timmywil changed the title from Hide jQuery.nodeName to Deprecate jQuery.nodeName, remove in 4.0 Jan 9, 2017

@karan-96
Contributor

karan-96 commented Jan 16, 2017

Hello . i think ,to fix up this issue, jquery.nodeName function should be removed from src/core.js and added to src/deprecated.js. Correct me if i am wrong or if i am missing something.Can i take up this issue and work with this approach?

timmywil referenced this issue in jquery/jquery-migrate Jan 16, 2017

Open

Warn about jQuery.nodeName removal #246

@timmywil
Owner

timmywil commented Jan 16, 2017

@karan-96 That would be great! You'll find information on how to contribute here, with info on commits and PRs here. As far as the required work for this issue, that should be all the work needed for jQuery core. We'll also want to add a warning to the jQuery migrate plugin.

@karan-96 karan-96 added a commit to karan-96/jquery that referenced this issue Jan 17, 2017

@karan-96 karan-96 Core: Deprecate jQuery.nodeName 
Fixes gh-3475
 75ee2f3

@karan-96 karan-96 added a commit to karan-96/jquery that referenced this issue Jan 17, 2017

@karan-96 karan-96 Core: Deprecate jQuery.nodeName 
Fixes gh-3475
 09e5246

karan-96 referenced this issue Jan 17, 2017

Closed

Core: Deprecate jQuery.nodeName #3505

0 of 4 tasks complete
@dmethvin
Owner

dmethvin commented Jan 23, 2017

Just to clarify what has to be done here, I know it's got a PR at gh-3505 but we have to eliminate internal calls in order to warn about it in jQuery Migrate.

  • Create an internal nodeName and put it in src/var/nodeName.js
  • Change all internal calls to jQuery.nodeName to our new nodeName function
  • Expose the internal nodeName as jQuery.nodeName in deprecated.js

Does that sound right to everyone?
@mgol
Member

mgol commented Jan 23, 2017

@dmethvin yes, that's exactly what I said in #3505 (comment) a few days ago. :)
@mgol
Member

mgol commented Jan 23, 2017

(although it seems it doesn't have to be a var-module in case of an exported function)
@dmethvin
Owner

dmethvin commented Jan 23, 2017

@mgol oh sorry, I missed that!

@karan-96 karan-96 added a commit to karan-96/jquery that referenced this issue Jan 27, 2017

@karan-96 karan-96 + karan-96 Core: Deprecate jQuery.nodeName 
Fixes gh-3475
 ce8974d

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Jan 27, 2017

karan-96 Core: jQuery.nodeName replaced 
Fixes gh-3475
 23eb560

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Jan 27, 2017

karan-96 Core: jQuery.nodeName replaced 
Fixes gh-3475
 5ec2bcd

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Jan 28, 2017

karan-96 Core: jQuery.nodeName replaced 
Fixes gh-3475
 e56c8e1

mgol added the Has Pull Request label Feb 13, 2017

mgol self-assigned this Feb 13, 2017

@karan-96 karan-96 added a commit to karan-96/jquery that referenced this issue Feb 16, 2017

@karan-96 karan-96 + karan-96 Core: Deprecate jQuery.nodeName 
Fixes gh-3475
 df46809

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Feb 16, 2017

karan-96 Core: jQuery.nodeName replaced 
Fixes gh-3475
 41a01c3

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Feb 16, 2017

karan-96 Core: jQuery.nodeName replaced 
Fixes gh-3475
 9f3d2e8

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Feb 16, 2017

karan-96 Core: jQuery.nodeName replaced 
Fixes gh-3475
 78e1c0c

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Feb 16, 2017

karan-96 Core: Deprecate jQuery.nodeName 
Fixes gh-3475
 a4ad702

@karan-96 karan-96 pushed a commit to karan-96/jquery that referenced this issue Feb 21, 2017

karan-96 Core: Deprecate jQuery.nodeName 
Fixes gh-3475
 1bc3de5

mgol closed this in ac9e301 Mar 1, 2017

@wmfphab wmfphab pushed a commit to wikimedia/mediawiki that referenced this issue Mar 18, 2017

Fomafix Replace deprecated jQuery.nodeName 
jQuery.nodeName gets deprecated in jQuery 3.2.0. [1] [2]

[1] https://blog.jquery.com/2017/03/16/jquery-3-2-0-is-out/
[2] jquery/jquery#3475

Change-Id: I7e6d5191e4db5117dbcfa89b07f25e672ed1e4d2
 67bb65b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment