#13160 closed bug (fixed)
Deferred.then doesn't propagete custom context
| Reported by: | nanto_vi | Owned by: | jaubourg |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9 |
| Component: | deferred | Version: | 1.9b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
jQuery 1.9b1 changed a context (value of 'this') in piped promises.
- http://jsfiddle.net/8qCkf/1/ (1.8.2)
- http://jsfiddle.net/gUgMJ/1/ (1.9.0pre)
This change affects codes that expect context to be propagated such as:
function ajaxWithRescueFrom404(settings) {
return $.ajax(settings).then(null, function (xhr, status) {
return (xhr.status === 404)
? $.Deferred().resolveWith(this, ['', status, xhr])
: this;
});
}
ajaxWithResuceFrom404({ url: ... }).done(function () {
// Treat 404 response as same as succeeded response.
// Expect that 'this' is a settings object.
});
The commit https://github.com/nanto/jquery/commit/cdac527be80fb2c6585ce6f53a83d4a9144fbf4d fixes this problem.
Change History (5)
comment:1 Changed 6 years ago by
| Component: | unfiled → deferred |
|---|---|
| Milestone: | None → 1.9 |
| Owner: | set to jaubourg |
| Priority: | undecided → blocker |
| Status: | new → assigned |
comment:3 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Propagete context of returned deferred object in Deferred.then(). Fixes #13160
Changeset: e7fdda981928befda72b78e9e2b17e33e232a603
comment:4 Changed 6 years ago by
Propagate context of returned deferred object in Deferred.then(). Fixes #13160.
Changeset: 2f6b3f818fc51ee6ae44be69dc6b15b3d7a2dad4
comment:5 Changed 6 years ago by
Propagate context of returned deferred object in Deferred.then(). Fixes #13160.
Changeset: 0c5d2fbabb39ef53a798535bc58690d34ea21351

Can you make this a full-fledged pull request with unit tests to boot?