It looks like the callback invocation should be using this instead of self. Would you like to open a pull request?

@markelog This fix is making it into 1.12.3 & 2.2.3 so the milestone should reflect that. Why did you change that to 3.0.0?

And to 3.0 too, whereas master branch is a primary one. So why did you change the milestone, before clarifying?

Milestones are used to generate changelogs and for end users it doesn't
matter that 3.0.0 got the fix separately, for them it's fixed in
1.12.3/2.2.3 and just stays fixed in 3.0.0. That's why the older releases
get the milestone and that's what's we've been doing so far.

Also, if anyone, I should be the one asking why you changed the milestone
without claryfing.

Michał Gołębiowski

I think correct course of events is important, this issue looks like that the fix is only needed for 2.2-stable, whereas is it would incorrect to assume that.

for them it's fixed in 1.12.3/2.2.3 and just stays fixed in 3.0.0

That would be an incorrect, offensive commit was done against the 3.0 and ported to 2.x/1.x,
not to mentioned to we already released several versions of 3.x, pre-releases but releases nonetheless, which has this bug, now you propose to omit this commit and thereby deprive users from this information? All and all i don't understand why you propose to mislead our users, since i assumed you set the milestone by mistake and not on purpose, that is why i have changed the milestone.

This commit should be in both changelogs, milestone, in my opinion should be set on primary branch.

I disagree but I don't have anything else to add.

Thanks for the fix and quick release, now our app works again! :)