Opened 9 years ago
Closed 9 years ago
#8814 closed enhancement (fixed)
Unnecessary code in inArray
| Reported by: | timmywil | Owned by: | timmywil |
|---|---|---|---|
| Priority: | low | Milestone: | 1.next |
| Component: | core | Version: | 1.5.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I was looking through core.js and noticed the redefinition of inArray using indexOf if it exists. Since this overrides the function, we don't need to check for indexOf in the fallback inArray definition. pull request
Change History (3)
comment:1 Changed 9 years ago by
| Component: | unfiled → core |
|---|---|
| Owner: | set to timmywil |
| Priority: | undecided → low |
| Status: | new → assigned |
comment:3 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixes #8814. Clean up inArray.
Changeset: 8c40c00fac2f30fa0804ae8097642636f9718ddd
Note: See
TracTickets for help on using
tickets.
Building on timmywil's commit, I reduced the codesize further, with negligible performance loss:
https://github.com/jquery/jquery/pull/308
http://jsperf.com/init-time-vs-on-call