$().add(selectElement) adds option children instead

[ratbeard]

Passing a raw dom select element to jQuery.fn.add adds all of its option children to the collection, instead of the select element itself.

Array.prototype.slice.call() inside makeArray gets confused probably due to the select element having a length property.

Tested this in Chrome 5 and FF 3.6 on osx 10.6.

Workaround is to wrap the select element in jQuery()

[dmethvin]

There is a similar situation with form elements but it seems to be by intent because there is a test case to verify that adding a form actually adds the form.elements collection.

It seems that .add("form#mine") should do the same thing as .add(getElementById("mine")), and the same goes for select.

If that was the case, it might be easiest to fix this issue in makeArray by not turning DOMElement with .length into an array of its children.

[John Resig]

Make sure that forms and selects are added to a jQuery set correctly. Fixes #6912.

Changeset: 728a70c036dfcdc0c45c5c60c08aeade786ce195

[timmywil]

#6867 is a duplicate of this ticket.