Attribute selector fails if the attribute value contains :first :last

[nikolay.r.rusev@…]

Sizzle fails when parsing the following selector:

:input[myattr="value:FirstName"]

It seems like it treats :FirstName as :first pseudo selector. Same can be observed if the value is value:LastName or anything that looks like pseudo selector.

Removing the colon from :input will not trigger the error.

Here are some fiddles demonstrating the scenario:

• working(expected behavior) with version 1.7.1 - ​http://jsfiddle.net/z9SNK/
• not working with 1.8.0 - ​http://jsfiddle.net/fN7tp/
• some workaround with 1.8.0 - ​http://jsfiddle.net/mhwTY/

[sindresorhus]

I'm not sure why that worked in 1.7.1, but it is clearly wrong. You can't combine a pseudo selector with an attribute selector. If you need to select an attribute, then just use an tag and attribute selector like you do in your last jsfiddle.

Also it is deprecated and slow. Use attribute selector instead.

[nikolay.r.rusev@…]

You can't combine a pseudo selector with an attribute selector.

This isn't serious, is it? Where does the documentation states that both cannot be used?

Also it is deprecated and slow.

What is deprecated? Is it documented?

The value for attribute must not be treated as selector, but rather as plain text. Also please note that the behavior is triggered only if there is pseudo selector before the attribute selector. This isn't be normal.

Another example that prove it wrong:

• go to the selectors article: ​http://api.jquery.com/category/selectors/

quoted from the second paragraph

If you wish to use any of the meta-characters ( such as !"#$%&'()*+,./:;<=>?@[\]^{`{|}~ ) as a literal part of a name, you must escape the character with two backslashes:
.}

• see this fiddle(it selects element) - ​http://jsfiddle.net/8Dra6/
• this also does select the element - ​http://jsfiddle.net/Gw3sS/
• this one fails - ​http://jsfiddle.net/6srwv/

[gibson042]

No, this is valid. We're erroneously catching :first et. al. inside attribute selectors when we sweep for positional ones.

[dmethvin]

#12358 is a duplicate of this ticket.

[timmywil]

I went ahead and did an implementation for this.

@gibson042: I've created a Sizzle issue for the remaining POS problems here: ​https://github.com/jquery/sizzle/issues/148

[Timmy Willison]

Sizzle: POS selectors make more extensive use of tokenization. Fixes #12303.

​http://jqbug.com/12303

Changeset: 3a633b0082dbba0365c014ece03d39e8358da18b

[nikolay.r.rusev@…]

The fix actually doesn't work in jQuery 1.8.1.

"Uncaught RangeError: Maximum call stack size exceeded" exceptions is thrown. Tested in Chrome(21.0.1180.89 m), FF(15.0.1) and IE9. FF even crash when attempt to execute the query.

Here is an example with v. 1.8.1 ​http://jsbin.com/ecowez/2/edit

[timmywil]

Woopsie. Looks like tokenization was fixed and handlePOS doesn't recognize any part of the selector as POS, but it goes into an infinite loop because the codepath keeps going into handlePOS.

[timmywil]

Wow. You might think the tests I added would also go into an infinite loop, but they don't because the regex index for the POS regex is never reset and it returns false on the second check, thus handlePOS is not entered again the second time around. I'm flabbergasted.

[timmywil]

#12527 is a duplicate of this ticket.

[dmethvin]

#12524 is a duplicate of this ticket.

[Timmy Willison]

Update Sizzle: Fixes #12303, #12474, #12523, #12526, #12541.

Changeset: f7980d4d68e76147e6a9ddd7b30d379ddce7f222