Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upProgress doesn't fire after .then() for resolved promises #2013
Comments
This comment has been minimized.
This comment has been minimized.
|
I think this a dup of #2010 but I'll let @gibson042 make the final call. I would say that this may not work in the near future with |
homm
added a commit
to uploadcare/uploadcare-widget
that referenced
this issue
Jan 14, 2015
This comment has been minimized.
This comment has been minimized.
|
Extremely similar, but not quite a duplicate... @homm, would you like to submit a PR? Both the code and new tests should be straightforward. |
dmethvin
added
the
Deferred
label
Jan 15, 2015
gibson042
added a commit
to gibson042/jquery
that referenced
this issue
Apr 14, 2015
gibson042
referenced this issue
Apr 14, 2015
Closed
Deferred: Don't swallow progress of a resolved deferred in `then` #2210
gibson042
self-assigned this
Apr 14, 2015
gibson042
added a commit
that referenced
this issue
Apr 22, 2015
gibson042
closed this
in
002240a
Apr 22, 2015
homm
added a commit
to uploadcare/uploadcare-widget
that referenced
this issue
May 15, 2015
gibson042
added a commit
that referenced
this issue
Nov 10, 2015
lock
bot
locked as resolved and limited conversation to collaborators
Jun 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
homm commentedJan 14, 2015
Suppose we have the Deferred object and try to set handlers on progress for both
.promise()and.then()objects:This works as expected, both progress handlers will fire. But if we try to set progress handlers for resolved Deferred, the result will be different:
Only first handler will fire. The problem in tuples order.
Progresstuple come last, and therefor, when newDefer.notify() is called, newDefer is already resolved and doesn't accept notifying.This bug is similar to #1894, but slightly different.