Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outerWidth of svg yields NaNpx. Previously yielded a number. #3964

Closed
AlexEdgcomb opened this issue Feb 6, 2018 · 5 comments
Closed

outerWidth of svg yields NaNpx. Previously yielded a number. #3964

AlexEdgcomb opened this issue Feb 6, 2018 · 5 comments
Assignees
@jbedard
Labels
Dimensions Has Pull Request
Milestone
3.4.0

Comments

@AlexEdgcomb
Copy link

@AlexEdgcomb AlexEdgcomb commented Feb 6, 2018

Description

On v3.3.1, outerWidth() of an svg yields NaNpx.

I expected a number. Prior versions (e.g., v3.2.1) yielded a number.

Issue reproduces on each OS/browser combo I tried: Mac/{Chrome, Firefox, Safari} and Windows/{Edge, Firefox, Chrome}.

Link to test case

v3.3.1: https://jsfiddle.net/u9pk0gdq/1/ (yields NaNpx)

v3.2.1: https://jsfiddle.net/378suvLg/ (yields a number)
@gibson042
Copy link
Member

@gibson042 gibson042 commented Feb 6, 2018

Hmm, interesting. SVG elements don't have offsetWidth or offsetHeight, so boxModelAdjustment gets NaN when trying to calculate their scroll gutters. This can be fixed by adding an || 0 in the final delta adjustment and covering SVG dimension getters with unit tests. Would you like to contribute a PR, @AlexEdgcomb?
@gibson042 gibson042 added the Dimensions label Feb 6, 2018
@AlexEdgcomb
Copy link
Author

@AlexEdgcomb AlexEdgcomb commented Feb 6, 2018

@gibson042 , I appreciate the offer, but I'll pass this round. Thanks!
@gibson042 gibson042 added this to the 3.4.0 milestone Feb 12, 2018
@averagehuman0G
Copy link

@averagehuman0G averagehuman0G commented Feb 27, 2018

@gibson042 I'd like to give this a shot, could it be assigned to me?
@mgol
Copy link
Member

@mgol mgol commented Feb 27, 2018

@jonathanv3232 GitHub doesn't allow to assign issues to people without commit access to the repo so we can't set you but feel free to take a shot at a PR!
This was referenced Mar 27, 2018
Closed
Closed
@kktam
Copy link

@kktam kktam commented Mar 27, 2018

Submitted PR for the fix.
jbedard added a commit to jbedard/jquery that referenced this issue Jun 4, 2018
@jbedard
Dimensions: fix computing outwerWidth on SVGs
d2fbdc8 
Fixes jquerygh-3964
jbedard added a commit to jbedard/jquery that referenced this issue Jun 11, 2018
@jbedard
Dimensions: fix computing outwerWidth on SVGs
12505f0 
Fixes jquerygh-3964
jbedard added a commit to jbedard/jquery that referenced this issue Jun 11, 2018
@jbedard
Dimensions: fix computing outerWidth on SVGs
6a97bba 
Fixes jquerygh-3964
@jbedard jbedard mentioned this issue Jun 11, 2018
Merged
0 of 4 tasks complete
@jbedard jbedard self-assigned this Jun 11, 2018
jbedard added a commit to jbedard/jquery that referenced this issue Jun 12, 2018
@jbedard
Dimensions: fix computing outerWidth on SVGs
7973c30 
Fixes jquerygh-3964
jbedard added a commit that referenced this issue Jun 21, 2018
@jbedard
Dimensions: fix computing outerWidth on SVGs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e743cbd 
Fixes gh-3964
Closes gh-4096
@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbedard jbedard

Labels
Dimensions Has Pull Request
Projects
None yet
Milestone
3.4.0
Linked pull requests

Successfully merging a pull request may close this issue.

Dimensions: fix computing outerWidth on SVGs
6 participants
@jbedard @gibson042 @mgol @kktam @AlexEdgcomb @averagehuman0G