#11435 closed bug (fixed)
Obsolete test code to remove toJSON from .data's return value
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | low | Milestone: | 1.8 |
| Component: | data | Version: | git |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The ".data()" test in test/unit/data.js has this code (in 2 places):
// TODO: Remove this hack which was introduced for 1.5.1 delete dataObj.toJSON;
Commit d5f144a7 changed the way jQuery.data() works so that the .toJSON isn't included, so I think this code is no longer necessary. I removed it and the test still passed.
Change History (4)
comment:1 Changed 8 years ago by
| Priority: | undecided → low |
|---|---|
| Status: | new → open |
comment:2 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Fix #11435. Remove obsolete test code.
Changeset: dc337f628c0d2a4f6d691851eb95a622599e38b2
comment:3 Changed 7 years ago by
| Milestone: | None → 1.8 |
|---|
comment:4 Changed 7 years ago by
| Component: | unfiled → data |
|---|
Note: See
TracTickets for help on using
tickets.
This was just mentioned in -meeting and it looks like we're going to try addressing it. Marking as valid.