Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.then improperly propagates progress from locked-in Deferred #3062

Closed
gibson042 opened this issue Apr 15, 2016 · 2 comments
Closed

.then improperly propagates progress from locked-in Deferred #3062

gibson042 opened this issue Apr 15, 2016 · 2 comments
Assignees
@gibson042 @mgol
Labels
Deferred Has Pull Request
Milestone
3.0.0

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Apr 15, 2016

When .then locks in a Deferred by rebinding to a thenable resolved by its base, progress context is inappropriately propagated as progress data, and progress data is in appropriately wrapped in an array. It's probably easier to explain in code than in natural language: https://jsfiddle.net/zwavzvpx/ .

This happens because .notify is used where .notifyWith belongs, at deferred.js#L131.
@gibson042 gibson042 self-assigned this Apr 15, 2016
@gibson042 gibson042 added this to the 3.0.1 milestone Apr 15, 2016
@mgol mgol mentioned this issue May 26, 2016
Closed
@mgol
Copy link
Member

@mgol mgol commented May 26, 2016

We got an external report as well and as far as I understand it's a regression so I added the "Needs review" label as we might want that for 3.0.0.
@mgol mgol self-assigned this Jun 8, 2016
@mgol mgol added this to the 3.0.0 milestone Jun 8, 2016
@mgol mgol removed this from the 3.0.1 milestone Jun 8, 2016
mgol added a commit to mgol/jquery that referenced this issue Jun 8, 2016
@mgol
Deferred: Propagate progress correctly from unwrapped promises
6b3440a 
Progress parameters are now correctly propagated from a deferred to which
another deferred resolved unwrapping it.

Thanks to @gibson042 for the report and a clear description of the problem
and the needed fix.

Fixes jquerygh-3062
@mgol mgol mentioned this issue Jun 8, 2016
Merged
4 tasks
@mgol
Copy link
Member

@mgol mgol commented Jun 8, 2016

PR: #3150. Please review, I want to get it in 3.0.0. And thanks @gibson042 for a clear description of the situation and the needed fix!
mgol added a commit to mgol/jquery that referenced this issue Jun 9, 2016
@mgol
Deferred: Propagate progress correctly from unwrapped promises
d5dae25 
Progress parameters are now correctly propagated from a deferred to which
another deferred resolved unwrapping it.

Thanks to @gibson042 for the report and a clear description of the problem
and the needed fix.

Fixes jquerygh-3062
Closes jquerygh-3150
@mgol mgol closed this in #3150 Jun 9, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gibson042 gibson042

@mgol mgol

Labels
Deferred Has Pull Request
Projects
None yet
Milestone
3.0.0
Linked pull requests

Successfully merging a pull request may close this issue.

Deferred: Propagate progress correctly from unwrapped promises
2 participants
@gibson042 @mgol