Range for object literal shorthand methods doesn't include params #1029

ariya · 2015-02-13T14:24:16Z

What steps will reproduce the problem?

On a fresh checkout of the harmony branch:

// test.js
var esprima = require('./');

var source = [
    '({',
    '    method1(arg1) {},',
    '})'
].join('\n');

var ast = esprima.parse(source, { range: true });

console.log(ast.body[0].expression.properties[0]);
console.log(ast.body[0].expression.properties[0].value.params[0]);

$ node test.js
{ type: 'Property',
  key: { type: 'Identifier', name: 'method1', range: [ 7, 14 ] },
  value:
   { type: 'FunctionExpression',
     id: null,
     params: [ [Object] ],
     defaults: [],
     body: { type: 'BlockStatement', body: [], range: [Object] },
     rest: null,
     generator: false,
     expression: false,
     range: [ 21, 23 ] },
  kind: 'init',
  method: true,
  shorthand: false,
  computed: false,
  range: [ 7, 23 ] }
{ type: 'Identifier', name: 'arg1', range: [ 15, 19 ] }

What is the expected output?

I would expect the FunctionExpression's range to include the method's parameters as well as the body as in (arg1) {}.

It makes sense that the method's name is not included, as that is the Property's key and does not belong to the FunctionExpression.

What do you see instead?

The FunctionExpression's range includes only the body, {}, leading to a scenario in which a traversal starting at the FunctionExpression, range 21-23, would reach the parameter, whose range, 15-19, lies outside that of its parent.

(Migrated from https://code.google.com/p/esprima/issues/detail?id=625, as reported by @btmills)

Previously, the range and loc for get, set, and shorthand methods inside object literal properties included only the method body, meaning a method's parameters were outside the range of their parent `FunctionExpression` node. This was happening because the `FunctionExpression` node wasn't being created until `parsePropertyFunction` was called, by which point the method's parameters had already been parsed. This PR solves the issue by creating the `FunctionExpression` node as soon as it determines that the property is a get, set, or shorthand method, then passing the node into `parsePropertyFunction`. Closes jquery#1029

ariya · 2015-02-15T06:01:23Z

I took a look at property setter and it seems to have the same problem: #1040.

Previously, the range and loc for get, set, and shorthand methods inside object literal properties included only the method body, meaning a method's parameters were outside the range of their parent `FunctionExpression` node. This was happening because the `FunctionExpression` node wasn't being created until `parsePropertyFunction` was called, by which point the method's parameters had already been parsed. This PR solves the issue by creating the `FunctionExpression` node as soon as it determines that the property is a get, set, or shorthand method, then passing the node into `parsePropertyFunction`. Closes jquery#1029 Closes jquery#1040

ariya added the defect label Feb 13, 2015

This was referenced Feb 14, 2015

generator-star ignores object literal shorthand methods eslint/eslint#1680

Closed

Object literal shorthand generator methods have incorrect range eslint/espree#36

Closed

btmills mentioned this issue Feb 14, 2015

Expand property method range and loc to include params #1036

Closed

ariya closed this in 3844589 Feb 16, 2015

millermedeiros mentioned this issue Mar 11, 2015

object getter and setter are not formatted properly if using esprima@2.1 millermedeiros/esformatter#265

Closed

jquery / esprima

Range for object literal shorthand methods doesn't include params #1029

Range for object literal shorthand methods doesn't include params #1029

ariya commented Feb 13, 2015

ariya commented Feb 15, 2015

jquery / esprima

Join GitHub today

GitHub is where the world builds software

Range for object literal shorthand methods doesn't include params #1029

Range for object literal shorthand methods doesn't include params #1029

Comments

ariya commented Feb 13, 2015

ariya commented Feb 15, 2015

Essential cookies

Always active

Analytics cookies