Opened 6 years ago
Closed 6 years ago
#14731 closed bug (fixed)
Checking .css('marginRight') after width() can give incorrect results
| Reported by: | m_gol | Owned by: | m_gol |
|---|---|---|---|
| Priority: | low | Milestone: | 1.11.1 |
| Component: | css | Version: | 1.11.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
As @timmywil discovered here (with help from @jdalton):
https://github.com/jquery/jquery/commit/bbbdd947256a3fcd788fb9d4f306046082a1ef1f#commitcomment-5173866
we're caching the reliableMarginRight support test result in a variable that is also pre-set when computing the boxSizingReliable support test. This leads to an incorrect test result and can lead to erroneous output.
The reliableMarginRight caching can just be removed since the function is executed only once, in the addGetHookIf function. This will solve the bug.
2.x doesn't have this problem.
Change History (2)
comment:1 Changed 6 years ago by
| Component: | unfiled → css |
|---|---|
| Milestone: | None → 1.11.1 |
| Owner: | set to m_gol |
| Priority: | undecided → low |
| Status: | new → assigned |
comment:2 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Fixed in https://github.com/jquery/jquery/commit/4cbb1a0063d06ddece8982b868298e90aefa2d08