Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM inserted scripts should support script type module #3871

Closed
tbepdb opened this issue Dec 4, 2017 · 3 comments
Closed

DOM inserted scripts should support script type module #3871

tbepdb opened this issue Dec 4, 2017 · 3 comments
Assignees
@tbepdb
Labels
Has Pull Request
Milestone
3.3.0

Comments

@tbepdb
Copy link
Contributor

@tbepdb tbepdb commented Dec 4, 2017

Description

I'm using JQuery version 3.2.1 in Chromium 62+ and I'm trying to use es6 native modules.
When i use code like that

$('selector').html('<script type="module" scr="PATH/file.js"></script>')

jquery has not execute that script.

Link to test case

test case
@tbepdb tbepdb mentioned this issue Dec 4, 2017
Closed
4 of 4 tasks complete
@timmywil
Copy link
Member

@timmywil timmywil commented Dec 4, 2017

Thank you for opening an issue! We agree this is an issue worth addressing, but we need a test case that will actually pass once we do address it.
@tbepdb
Copy link
Contributor Author

@tbepdb tbepdb commented Dec 4, 2017

Excuse me i don't have expirience with "plunker" service. I forgot "freeze" test case
@gibson042
Copy link
Member

@gibson042 gibson042 commented Dec 4, 2017 •
edited

https://jsbin.com/xusahimado/edit?html,js,console,output
@timmywil timmywil added this to the 3.3.0 milestone Dec 18, 2017
timmywil added a commit to timmywil/jquery that referenced this issue Jan 16, 2018
@timmywil
Tests: ensure that module assertions run on supported browsers
Verified
This commit was signed with a verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about signing commits
625e19c 
- Also fixes tests for karma, where the URL for the module is different

Ref jquerygh-3871
@timmywil timmywil closed this in 5d3a968 Jan 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbepdb tbepdb

Labels
Has Pull Request
Projects
None yet
Milestone
3.3.0
Linked pull requests

Successfully merging a pull request may close this issue.

Manipulation: Add support script type module
3 participants
@timmywil @gibson042 @tbepdb
You can’t perform that action at this time.