Skip to content

/jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jQuery.each and jQuery#each signatures #2090

Closed
markelog opened this issue Feb 13, 2015 · 1 comment

Comments

Assignees

@markelog markelog

Labels
Core
Projects
None yet
Milestone
  1.12.0/2.2.0
3 participants
@markelog @gibson042 @dmethvin
@markelog
Copy link
Member

commented Feb 13, 2015

Since we use second argument only in one place and it was always documented as being internal it might be good time to remove it.

Since it will decrease size and improve performance.

@markelog markelog added the Core label Feb 13, 2015

@markelog markelog referenced this issue Feb 13, 2015

Closed

Simplification, clarify and update some of the ajax logic #2033

@markelog markelog self-assigned this Feb 13, 2015

@gibson042

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 13, 2015

YES. 👍

@markelog markelog added this to the 3.0.0 milestone Feb 15, 2015

@markelog markelog changed the title Change jQuery.each and jQuery#each signature Change jQuery.each and jQuery#each signatures Feb 17, 2015

markelog added a commit to markelog/jquery that referenced this issue Feb 17, 2015

@markelog
Core: change jQuery.each and jQuery#each signatures 
Fixes jquerygh-2090
0105ea7

@markelog markelog referenced this issue Feb 17, 2015

Closed

Change jQuery.each and jQuery#each signatures #2097

markelog added a commit that referenced this issue Feb 19, 2015

@markelog
Ajax: remove use of jQuery#each second argument 
(cherry-picked from a4715f4)
Ref gh-2090
0877733

markelog added a commit that referenced this issue Feb 19, 2015

@markelog
Core: change jQuery.each and jQuery#each signatures 
(cherry-picked from 2380028)
Fixes gh-2090
Closes gh-2097
Loading status checks…
7cd9a36

markelog added a commit that referenced this issue Feb 19, 2015

@markelog
Ajax: remove use of jQuery#each second argument 
Ref gh-2090
a4715f4

@markelog markelog closed this in 2380028 Feb 19, 2015

markelog added a commit that referenced this issue Nov 10, 2015

@markelog
Ajax: remove use of jQuery#each second argument 
Ref gh-2090
da23273

markelog added a commit that referenced this issue Nov 10, 2015

@markelog
Core: change jQuery.each and jQuery#each signatures 
Fixes gh-2090
Closes gh-2097
6dcf432

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.