Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check for external dependencies extendable? #46

Open
jzaefferer opened this issue Mar 21, 2014 · 0 comments
Open

Make check for external dependencies extendable? #46

jzaefferer opened this issue Mar 21, 2014 · 0 comments

Comments

@jzaefferer
Copy link
Member

@jzaefferer jzaefferer commented Mar 21, 2014

Core currently requires md5sum, UI requires unzip. Arguably those could all be replaced with node modules. Both UI and Mobile have their own implementation for creating md5 sums. Last I checked, there was no decent unzip implementation in node (archiver only does zipping; node's zlib wrapper only handles compression, not the actual archiving).

If we make the check extendable, we'd have move or duplicate it, since it can only run after _cloneRepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.