Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update document-ready.md #726

Open
wants to merge 1 commit into
base: master
from
Open

Update document-ready.md #726

wants to merge 1 commit into from

Conversation

@riverma
Copy link

@riverma riverma commented Sep 7, 2016

$( window ).load(function () {}) deprecated since v1.8. Should use $( window ).on("load", function () {})
jquery/jquery#2286

$( window ).load(function () {}) deprecated since v1.8. Should use $( window ).on("load", function () {})
jquery/jquery#2286
@jquerybot
Copy link

@jquerybot jquerybot commented Sep 7, 2016

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@jquerybot jquerybot added the CLA: Error label Sep 7, 2016
@AurelioDeRosa
Copy link
Member

@AurelioDeRosa AurelioDeRosa commented Sep 11, 2016

Can you sign the CLA and also add a space before and after the "load" string to conform to our code style guide?

@JSFOwner JSFOwner removed the CLA: Error label Nov 5, 2016
@AurelioDeRosa
Copy link
Member

@AurelioDeRosa AurelioDeRosa commented Dec 20, 2016

Hi @riverma. Can you sign our CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants