Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken core.js file is dist packages #4489

Closed
stof opened this issue Sep 25, 2019 · 5 comments
Closed

Broken core.js file is dist packages #4489

stof opened this issue Sep 25, 2019 · 5 comments
Assignees
@mgol
Labels
Bug Build Has Pull Request
Milestone
3.5.0

Comments

@stof
Copy link

@stof stof commented Sep 25, 2019

Description

starting from 3.0.0-rc1, the jquery-dist repo contains a core.js file, which seems to be a copy of one of the source files. This file is not usable (it has AMD dependencies on other files which are not copied), so including it in the releases looks wrong.
@mgol
Copy link
Member

@mgol mgol commented Sep 26, 2019

Which AMD dependencies are not copied? The file should be usable.
@mgol mgol added the Needs info label Sep 26, 2019
@stof
Copy link
Author

@stof stof commented Sep 26, 2019

see https://github.com/jquery/jquery-dist/blob/3.4.1/dist/core.js

This files depends on a bunch of AMD dependencies which are not part of the distribution at all.
@stof
Copy link
Author

@stof stof commented Sep 26, 2019

files in src are fine. But this file is in the dist folder.
@mgol mgol added Bug Build and removed Needs info labels Sep 26, 2019
@mgol
Copy link
Member

@mgol mgol commented Sep 26, 2019

Ah, you're right! I don't know how that file gets there, there must be a bug in the release process. @timmywil any ideas?
@mgol mgol added this to the 3.5.0 milestone Sep 26, 2019
@mgol mgol added the Needs review label Sep 26, 2019
@mgol mgol self-assigned this Sep 26, 2019
mgol added a commit to mgol/jquery that referenced this issue Sep 26, 2019
@mgol
Build: Stop copying src/core.js to dist on release
0e9e718 
File `src/core.js` has started erroneously being copied to `dist/` in jquerygh-2981.

Fixes jquerygh-4489
Ref jquerygh-2979
Ref jquerygh-2981
@mgol mgol mentioned this issue Sep 26, 2019
Merged
2 of 2 tasks complete
@mgol
Copy link
Member

@mgol mgol commented Sep 26, 2019

It looks like it's enough to remove src/core.js from the files array as it was before. The version swapping should still work, I performed a test jquery-release run locally to confirm that.

PR: #4492
@mgol mgol added the Has Pull Request label Sep 26, 2019
mgol added a commit to mgol/jquery that referenced this issue Sep 30, 2019
@mgol
Build: Stop copying src/core.js to dist on release
42e47d9 
File `src/core.js` has started erroneously being copied to `dist/` in jquerygh-2981.

Fixes jquerygh-4489
Ref jquerygh-2979
Ref jquerygh-2981
mgol added a commit to mgol/jquery that referenced this issue Oct 2, 2019
@mgol
Build: Stop copying src/core.js to dist on release
8b86629 
File `src/core.js` has started erroneously being copied to `dist/` in jquerygh-2981.

Fixes jquerygh-4489
Ref jquerygh-2979
Ref jquerygh-2981
@mgol mgol closed this in #4492 Oct 4, 2019
mgol added a commit that referenced this issue Oct 4, 2019
@mgol
Build: Stop copying src/core.js to dist on release
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a4d980 
File `src/core.js` has started erroneously being copied to `dist/` in gh-2981.

Fixes gh-4489
Closes gh-4492
Ref gh-2979
Ref gh-2981
mgol added a commit that referenced this issue Oct 4, 2019
@mgol
Build: Stop copying src/core.js to dist on release
Loading status checks…
279d2e9 
File `src/core.js` has started erroneously being copied to `dist/` in gh-2981.

Fixes gh-4489
Closes gh-4492
Ref gh-2979
Ref gh-2981

(cherry picked from commit 9a4d980)
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Oct 4, 2019
Merged
0 of 4 tasks complete
@mgol mgol removed the Needs review label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
Bug Build Has Pull Request
Projects
None yet
Milestone
3.5.0
Linked pull requests

Successfully merging a pull request may close this issue.

Build: Stop copying src/core.js to dist on release
Fix rustdoc display with js disabled
2 participants
@stof @mgol