Skip to content

/ stencil-postcss

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update type declarations, allow context to be undefined #16

Open
wants to merge 2 commits into
base: master
from
Open

fix: update type declarations, allow context to be undefined #16

wants to merge 2 commits into from

Conversation

@DesignByOnyx
Copy link

DesignByOnyx commented May 30, 2019 •
edited

This updates the type declarations to be in sync with @stencil/core. This allows context to be undefined, which allows importing 3rd party styles.

Fixes #15
@DesignByOnyx DesignByOnyx force-pushed the DesignByOnyx:15-allow-undefined-context branch from 1d38ab8 to 195e437 May 30, 2019
@jcfranco jcfranco mentioned this pull request Jun 6, 2019
Closed
@DesignByOnyx
fix: update type declarations, allow context to be undefined
e66d6e7 
This updates the type declarations to be in sync with @stencil/core. This also allows context to be undefined, which allows importing 3rd party styles.

Fixes #15
@DesignByOnyx
test(util): write test to cover new context logic
853fe03
@DesignByOnyx DesignByOnyx force-pushed the DesignByOnyx:15-allow-undefined-context branch from 195e437 to 853fe03 Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Update type declarations, should also work if context is undefined
1 participant
@DesignByOnyx
You can’t perform that action at this time.