Skip to content

/ concise.css

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The need for pxToRem function #135

Closed
relector-tuxnix opened this issue Apr 24, 2016 · 2 comments
Closed

The need for pxToRem function #135

relector-tuxnix opened this issue Apr 24, 2016 · 2 comments
Assignees
@jameskolce
Labels
type:feature

Comments

@relector-tuxnix
Copy link

@relector-tuxnix relector-tuxnix commented Apr 24, 2016 

@function pxToRem($px, $base: $font-base-size) {
  @return ($px / $base) + rem;
}
@jameskolce jameskolce self-assigned this Apr 24, 2016
@jameskolce
Copy link
Contributor

@jameskolce jameskolce commented Apr 24, 2016

Thank you! I'll add it soon. Will be available in the next release.
jameskolce added a commit that referenced this issue Apr 27, 2016
@jameskolce
[ref: #135] Add pxToRem function
4d2f42d
@jameskolce
Copy link
Contributor

@jameskolce jameskolce commented Apr 27, 2016

Alright, I added the new function, it only accepts one parameter (px value). Since Rem is based in the root font-size I don't think it's useful to have a base parameter, however I can add it if turns out to be necessary.
@jameskolce jameskolce closed this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskolce jameskolce

Labels
type:feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@relector-tuxnix @jameskolce
You can’t perform that action at this time.