Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly detect attachment of Shadow DOM elements #3504

Closed
gibson042 opened this issue Jan 16, 2017 · 2 comments
Closed

Properly detect attachment of Shadow DOM elements #3504

gibson042 opened this issue Jan 16, 2017 · 2 comments
Assignees
@gibson042
Labels
Bug Has Pull Request
Milestone
3.4.0

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Jan 16, 2017

There are a few places where we check document attachment with jQuery.contains( elem.ownerDocument, elem ) (isHiddenWithinTree for show/hide, curCSS for inline style fallback, buildFragment/domManip/remove/jQuery.clone for managing script evaluation during DOM manipulation), all of which fail inside Shadow DOM:

$.contains(document, elem) will return false when elem is shown in a shadow dom.
change to elem.getRootNode({composed: true}) === elem.ownerDocument works.

We should investigate the cost of a remedy (e.g., a Shadow-DOM-compatible isAttached( elem ) function).
@timmywil
Copy link
Member

@timmywil timmywil commented Feb 6, 2017

Yes to going forward and investigating, but we may scrap it later depending on how involved this gets.
@timmywil timmywil removed the Needs review label Feb 6, 2017
@gibson042
Copy link
Member Author

@gibson042 gibson042 commented Feb 6, 2017

As noted in the meeting, we'd probably benefit from an internal isAttached even if it doesn't handle shadow DOM, because it better communicates intent.
@timmywil timmywil added this to the 3.2.0 milestone Feb 13, 2017
@timmywil timmywil modified the milestones: 3.3.0, 3.2.0 Mar 6, 2017
@timmywil timmywil modified the milestones: 3.3.0, 3.4.0 Nov 13, 2017
@timmywil timmywil mentioned this issue Jan 22, 2018
Open
SaptakS added a commit to SaptakS/jquery that referenced this issue Feb 14, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
10715f6 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
@SaptakS SaptakS mentioned this issue Feb 14, 2018
Merged
2 of 2 tasks complete
SaptakS added a commit to SaptakS/jquery that referenced this issue Feb 14, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
0a7d7d7 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
SaptakS added a commit to SaptakS/jquery that referenced this issue Feb 14, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
6dd405c 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
SaptakS added a commit to SaptakS/jquery that referenced this issue Feb 15, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
2a72502 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
SaptakS added a commit to SaptakS/jquery that referenced this issue Feb 16, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
ab5db2f 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
SaptakS added a commit to SaptakS/jquery that referenced this issue Feb 16, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
e972127 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
SaptakS added a commit to SaptakS/jquery that referenced this issue Feb 28, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
8b19101 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
SaptakS added a commit to SaptakS/jquery that referenced this issue Mar 2, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
cc3456a 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
@SaptakS SaptakS mentioned this issue Mar 2, 2018
Merged
2 of 3 tasks complete
SaptakS added a commit to SaptakS/jquery that referenced this issue Mar 2, 2018
@SaptakS
Core: Use isAttached to check for attachment of element
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
cb0ebc4 
This change replaces the use of contains to check for attachment
by isAttached function

Ref jquerygh-3504
mgol added a commit that referenced this issue Mar 5, 2018
@SaptakS @mgol
Core: Use isAttached to check for attachment of element
Loading status checks…
662083e 
This change replaces the use of contains to check for attachment
by isAttached function

Closes gh-3977
Ref gh-3504
SaptakS added a commit to SaptakS/jquery that referenced this issue Mar 5, 2018
@SaptakS
Core: Allow shadow DOM in attachment check
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
6a1d8a3 
Allow isAttached to check shadow DOM for attachment. This change allows
isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode()

Ref jquerygh-3504, jquerygh-3977
SaptakS added a commit to SaptakS/jquery that referenced this issue Mar 26, 2018
@SaptakS
Core: Allow shadow DOM in attachment check
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
b37ae7e 
Allow isAttached to check shadow DOM for attachment. This change allows
isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode()

Ref jquerygh-3504, jquerygh-3977
SaptakS added a commit to SaptakS/jquery that referenced this issue Apr 12, 2018
@SaptakS
Core: Allow shadow DOM in attachment check
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
be014fa 
Allow isAttached to check shadow DOM for attachment. This change allows
isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode()

Ref jquerygh-3504, jquerygh-3977
SaptakS added a commit to SaptakS/jquery that referenced this issue Apr 13, 2018
@SaptakS
Core: Allow shadow DOM in attachment check
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
740b191 
Allow isAttached to check shadow DOM for attachment. This change allows
isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode()

Ref jquerygh-3504, jquerygh-3977
SaptakS added a commit to SaptakS/jquery that referenced this issue Apr 13, 2018
@SaptakS
Core: Allow shadow DOM in attachment check
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
6ecc04a 
Allow isAttached to check shadow DOM for attachment. This change allows
isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode()

Ref jquerygh-3504, jquerygh-3977
SaptakS added a commit to SaptakS/jquery that referenced this issue Sep 24, 2018
@SaptakS
Core: Allow shadow DOM in attachment check
Unverified
This user has not uploaded their public key yet.
GPG key ID: B4A863E36FF55696 Learn about signing commits
e4762d4 
Allow isAttached to check shadow DOM for attachment. This change allows
isAttached() function to address shadowDOM elements even if the browser doesn't support getRootNode()

Ref jquerygh-3504, jquerygh-3977
@mgol mgol closed this in 9b77def Nov 9, 2018
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Nov 9, 2018
Merged
0 of 4 tasks complete
@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gibson042 gibson042

Labels
Bug Has Pull Request
Projects
None yet
Milestone
3.4.0
Linked pull requests

Successfully merging a pull request may close this issue.

Unable to install
2 participants
@timmywil @gibson042